From: Lars Ingebrigtsen <larsi@gnus.org>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: 45840@debbugs.gnu.org
Subject: bug#45840: 28.0.50; [PATCH] Remove hardcoded underline for perl-mode variables
Date: Tue, 19 Jan 2021 07:32:18 +0100 [thread overview]
Message-ID: <87o8hlmo7h.fsf@gnus.org> (raw)
In-Reply-To: <87sg757xw0.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Wed, 13 Jan 2021 15:46:23 +0200")
Protesilaos Stavrou <info@protesilaos.com> writes:
> The attached patch merely assigns font-lock-variable-name-face while
> removing the hardcoded underline property.
>
> If you think that the underline should remain in place, then I can
> provide another patch that would add a new face which would inherit from
> font-lock-variable-name-face and add an underline accordingly.
The comment here mentions this:
;; Additionally underline non-scalar variables. Maybe this is a bad idea.
;;'("[$@%*][#{]?\\(\\sw+\\)" 1 font-lock-variable-name-face)
("[$*]{?\\(\\sw+\\(::\\sw+\\)*\\)" 1 font-lock-variable-name-face)
("\\([@%]\\|\\$#\\)\\(\\sw+\\(::\\sw+\\)*\\)"
(2 (cons font-lock-variable-name-face '(underline))))
And it is a bad idea to hard-code this, but having different faces here
makes sense, I think. So could you whip up another patch to add the new
face, as you suggested?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-01-19 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 13:46 bug#45840: 28.0.50; [PATCH] Remove hardcoded underline for perl-mode variables Protesilaos Stavrou
2021-01-19 6:32 ` Lars Ingebrigtsen [this message]
2021-01-19 7:07 ` Protesilaos Stavrou
2021-01-19 7:11 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8hlmo7h.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=45840@debbugs.gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).