From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45840: 28.0.50; [PATCH] Remove hardcoded underline for perl-mode variables Date: Tue, 19 Jan 2021 07:32:18 +0100 Message-ID: <87o8hlmo7h.fsf@gnus.org> References: <87sg757xw0.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27455"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45840@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 19 07:57:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1kx6-000734-Ej for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 07:57:20 +0100 Original-Received: from localhost ([::1]:54052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1kx5-0002BO-GM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 01:57:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1kZa-0003pm-RE for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 01:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1kZa-0004Fg-IN for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 01:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1kZa-00063f-FL for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 01:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jan 2021 06:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45840 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45840-submit@debbugs.gnu.org id=B45840.161103795022934 (code B ref 45840); Tue, 19 Jan 2021 06:33:02 +0000 Original-Received: (at 45840) by debbugs.gnu.org; 19 Jan 2021 06:32:30 +0000 Original-Received: from localhost ([127.0.0.1]:49206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1kZ3-0005xh-Go for submit@debbugs.gnu.org; Tue, 19 Jan 2021 01:32:29 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:55384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1kZ1-0005sg-Rc for 45840@debbugs.gnu.org; Tue, 19 Jan 2021 01:32:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E88FdXhunLeCEJgxzwNuP4ofpn0xnC59dk8YECXT6BM=; b=TActAK3fQWVIs94xn6wlnNf1ZT abK9f5SfKCE8asPuXo3shsxY9tOX0Y5PGpyFbCteiO/cF65yURgAxviSjeUWgOl25Wj6eJTZ5JSbV MbTsh0VC0fZad7TUJ5+TvaFnuBDocaB2f9uZYZOrZbuM9ufgM/C+y4hagFKgOidQC65Y=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1kYt-0004Rz-No; Tue, 19 Jan 2021 07:32:22 +0100 X-Now-Playing: Rianbow Brown's _For Discos Only (2)_: "Till you surrender (Special Remix)" In-Reply-To: <87sg757xw0.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Wed, 13 Jan 2021 15:46:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198137 Archived-At: Protesilaos Stavrou writes: > The attached patch merely assigns font-lock-variable-name-face while > removing the hardcoded underline property. > > If you think that the underline should remain in place, then I can > provide another patch that would add a new face which would inherit from > font-lock-variable-name-face and add an underline accordingly. The comment here mentions this: ;; Additionally underline non-scalar variables. Maybe this is a bad idea. ;;'("[$@%*][#{]?\\(\\sw+\\)" 1 font-lock-variable-name-face) ("[$*]{?\\(\\sw+\\(::\\sw+\\)*\\)" 1 font-lock-variable-name-face) ("\\([@%]\\|\\$#\\)\\(\\sw+\\(::\\sw+\\)*\\)" (2 (cons font-lock-variable-name-face '(underline)))) And it is a bad idea to hard-code this, but having different faces here makes sense, I think. So could you whip up another patch to add the new face, as you suggested? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no