unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Ramesh Nedunchezian <rameshnedunchezian@outlook.com>,
	47566@debbugs.gnu.org
Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep'
Date: Thu, 08 Apr 2021 21:57:18 +0300	[thread overview]
Message-ID: <87o8eo38q9.fsf@mail.linkov.net> (raw)
In-Reply-To: <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> (Dmitry Gutov's message of "Wed, 7 Apr 2021 01:44:07 +0300")

> (defun hl-test ()
>   (interactive)
>   (message "OK")
>   (message "result: %s"
>            (y-or-n-p "Yes? ")))
>
> (defvar hl-repeat-map
>   (let ((map (make-sparse-keymap)))
>     (define-key map (kbd "n") 'hl-test) ; Note the changed key binding.
>     map)
>   "Keymap to repeat hl-test.")
>
> (put 'hl-test 'repeat-map 'hl-repeat-map)
>
> To try it:
>
> 1. M-x hl-test.
> 2. Press 'n' a few times.
>
> Expected behavior:
>
> It alternates between the prompt "Yes? " and message "result: nil".
>
> Actual behavior:
>
> It enters some sort of recursive state, only showing the prompt. I have to
> press 'y' a bunch of times to get out of it.

Thanks for the detailed test case.  Now it's fixed in 580c4c6510.





  reply	other threads:[~2021-04-08 18:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02  5:40 bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Ramesh Nedunchezian
2021-04-03 22:08 ` Dmitry Gutov
2021-04-05 20:43   ` Juri Linkov
2021-04-06 22:44     ` Dmitry Gutov
2021-04-08 18:57       ` Juri Linkov [this message]
2021-04-10  1:40         ` Dmitry Gutov
2021-04-10  8:38           ` Ramesh Nedunchezian
2021-04-10 22:59             ` Juri Linkov
2021-04-11  6:48               ` Ramesh Nedunchezian
2021-04-11 22:51                 ` Juri Linkov
2021-04-12 16:16                 ` Juri Linkov
2021-04-10 22:58           ` Juri Linkov
2021-04-10 23:27             ` Dmitry Gutov
2021-04-12 16:17               ` Juri Linkov
2021-04-13 23:54                 ` Dmitry Gutov
2021-04-14  7:14                   ` Kévin Le Gouguec
2021-04-14 18:10                     ` Juri Linkov
2021-04-14 19:12                       ` Kévin Le Gouguec
2021-04-14 19:52                         ` Juri Linkov
2021-04-14 20:21                           ` Juri Linkov
2021-04-14 20:48                           ` Kévin Le Gouguec
2021-04-14 21:58                             ` Juri Linkov
2021-04-14 23:35                       ` Dmitry Gutov
2021-11-14 20:25         ` Juri Linkov
2021-11-15  5:26           ` Lars Ingebrigtsen
2021-11-15 17:40             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8eo38q9.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=47566@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=rameshnedunchezian@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).