From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 47566-done@debbugs.gnu.org,
Ramesh Nedunchezian <rameshnedunchezian@outlook.com>
Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep'
Date: Sat, 10 Apr 2021 04:40:49 +0300 [thread overview]
Message-ID: <7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru> (raw)
In-Reply-To: <87o8eo38q9.fsf@mail.linkov.net>
On 08.04.2021 21:57, Juri Linkov wrote:
> Thanks for the detailed test case. Now it's fixed in 580c4c6510.
Thanks! repeat-mode is looking good now (*).
I've added integration for it to diff-hl master, and with that we can
close this issue.
Thanks all.
(*) Though the first impression, in comparison, was that it is too
chatty. The hints are definitely helpful for discovery at first, though.
Maybe something like this would be an improvement? Experimental code
warning.
diff --git a/lisp/repeat.el b/lisp/repeat.el
index b3c58f2f81..e704e4da56 100644
--- a/lisp/repeat.el
+++ b/lisp/repeat.el
@@ -404,7 +404,7 @@ repeat-post-hook
(key-description repeat-exit-key))
""))))
(if (current-message)
- (message "%s [%s]" (current-message) mess)
+ (message #("%s [%s]" 3 7 (face deemphasized))
(current-message) mess)
(message mess))))
;; Adding an exit key
next prev parent reply other threads:[~2021-04-10 1:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 5:40 bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Ramesh Nedunchezian
2021-04-03 22:08 ` Dmitry Gutov
2021-04-05 20:43 ` Juri Linkov
2021-04-06 22:44 ` Dmitry Gutov
2021-04-08 18:57 ` Juri Linkov
2021-04-10 1:40 ` Dmitry Gutov [this message]
2021-04-10 8:38 ` Ramesh Nedunchezian
2021-04-10 22:59 ` Juri Linkov
2021-04-11 6:48 ` Ramesh Nedunchezian
2021-04-11 22:51 ` Juri Linkov
2021-04-12 16:16 ` Juri Linkov
2021-04-10 22:58 ` Juri Linkov
2021-04-10 23:27 ` Dmitry Gutov
2021-04-12 16:17 ` Juri Linkov
2021-04-13 23:54 ` Dmitry Gutov
2021-04-14 7:14 ` Kévin Le Gouguec
2021-04-14 18:10 ` Juri Linkov
2021-04-14 19:12 ` Kévin Le Gouguec
2021-04-14 19:52 ` Juri Linkov
2021-04-14 20:21 ` Juri Linkov
2021-04-14 20:48 ` Kévin Le Gouguec
2021-04-14 21:58 ` Juri Linkov
2021-04-14 23:35 ` Dmitry Gutov
2021-11-14 20:25 ` Juri Linkov
2021-11-15 5:26 ` Lars Ingebrigtsen
2021-11-15 17:40 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru \
--to=dgutov@yandex.ru \
--cc=47566-done@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rameshnedunchezian@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).