bug#49800: 28.0.50; [PATCH] Extend Gnus summary highlight faces by default

bug#49800: 28.0.50; [PATCH] Extend Gnus summary highlight faces by default

[Kévin Le Gouguec]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hello,

This is a followup to bug#47026, where we made
gnus-summary-highlight-line and gnus-highlight-selected-summary apply
the highlighting face up to and including the final newline.

In this new patch, I went over the faces in gnus-summary-highlight and
added :extend t to all of them.  Even though most of them have no
background or underline set in the default theme, :extend's special
handling means that other themes will not need to set that property
explicitly.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Extend-Gnus-summary-highlight-faces-by-default.patch --]
[-- Type: text/x-diff, Size: 3213 bytes --]

From 8b58af09b040acf7498f358747909e1af039deb8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?K=C3=A9vin=20Le=20Gouguec?= <kevin.legouguec@gmail.com>
Date: Sat, 31 Jul 2021 23:54:06 +0200
Subject: [PATCH] Extend Gnus summary highlight faces by default

* lisp/gnus/gnus.el (gnus-summary-selected):
(gnus-summary-normal-ancient):
(gnus-summary-normal-undownloaded):
(gnus-summary-normal-unread):
(gnus-summary-normal-read): Set :extend attribute.
---
 lisp/gnus/gnus.el | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el
index 7dde799a5b..8b93acccca 100644
--- a/lisp/gnus/gnus.el
+++ b/lisp/gnus/gnus.el
@@ -525,25 +525,26 @@ gnus-group-mail-low
 
 ;; Summary mode faces.
 
-(defface gnus-summary-selected '((t (:underline t)))
+(defface gnus-summary-selected '((t (:underline t :extend t)))
   "Face used for selected articles."
   :group 'gnus-summary)
 
 (defface gnus-summary-cancelled
   '((((class color))
-     (:foreground "yellow" :background "black")))
+     (:foreground "yellow" :background "black" :extend t))
+    (t (:extend t)))
   "Face used for canceled articles."
   :group 'gnus-summary)
 
 (defface gnus-summary-normal-ticked
   '((((class color)
       (background dark))
-     (:foreground "pink"))
+     (:foreground "pink" :extend t))
     (((class color)
       (background light))
-     (:foreground "firebrick"))
+     (:foreground "firebrick" :extend t))
     (t
-     ()))
+     (:extend t)))
   "Face used for normal interest ticked articles."
   :group 'gnus-summary)
 
@@ -560,12 +561,12 @@ gnus-summary-low-ticked
 (defface gnus-summary-normal-ancient
   '((((class color)
       (background dark))
-     (:foreground "SkyBlue"))
+     (:foreground "SkyBlue" :extend t))
     (((class color)
       (background light))
-     (:foreground "RoyalBlue"))
+     (:foreground "RoyalBlue" :extend t))
     (t
-     ()))
+     (:extend t)))
   "Face used for normal interest ancient articles."
   :group 'gnus-summary)
 
@@ -582,10 +583,10 @@ gnus-summary-low-ancient
 (defface gnus-summary-normal-undownloaded
    '((((class color)
        (background light))
-      (:foreground "cyan4" :bold nil))
+      (:foreground "cyan4" :bold nil :extend t))
      (((class color) (background dark))
-      (:foreground "LightGray" :bold nil))
-     (t (:inverse-video t)))
+      (:foreground "LightGray" :bold nil :extend t))
+     (t (:inverse-video t :extend t)))
   "Face used for normal interest uncached articles."
   :group 'gnus-summary)
 
@@ -601,7 +602,7 @@ gnus-summary-low-undownloaded
 
 (defface gnus-summary-normal-unread
   '((t
-     ()))
+     (:extend t)))
   "Face used for normal interest unread articles."
   :group 'gnus-summary)
 
@@ -618,12 +619,12 @@ gnus-summary-low-unread
 (defface gnus-summary-normal-read
   '((((class color)
       (background dark))
-     (:foreground "PaleGreen"))
+     (:foreground "PaleGreen" :extend t))
     (((class color)
       (background light))
-     (:foreground "DarkGreen"))
+     (:foreground "DarkGreen" :extend t))
     (t
-     ()))
+     (:extend t)))
   "Face used for normal interest read articles."
   :group 'gnus-summary)
 
-- 
2.20.1


[-- Attachment #3: Type: text/plain, Size: 765 bytes --]




In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0)
 of 2021-07-30 built on hirondell
Repository revision: 5f65b67daccf7f4f30274f147a1adb5142328c6d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Configured using:
 'configure --with-xwidgets --with-cairo'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

bug#49800: 28.0.50; [PATCH] Extend Gnus summary highlight faces by default

[Lars Ingebrigtsen]

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

> In this new patch, I went over the faces in gnus-summary-highlight and
> added :extend t to all of them.  Even though most of them have no
> background or underline set in the default theme, :extend's special
> handling means that other themes will not need to set that property
> explicitly.

Makes sense to me.  Pushed to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#49800: 28.0.50; [PATCH] Extend Gnus summary highlight faces by default

[Kévin Le Gouguec]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
>> In this new patch, I went over the faces in gnus-summary-highlight and
>> added :extend t to all of them.  Even though most of them have no
>> background or underline set in the default theme, :extend's special
>> handling means that other themes will not need to set that property
>> explicitly.
>
> Makes sense to me.  Pushed to Emacs 28.

Mmm, somehow I failed to include a couple of face names in the ChangeLog
entry…  I'm fairly certain I used C-x 4 a from a vc-diff buffer?

Sorry about that 😕  I'll be sure to triple-check the message next time.

bug#49800: 28.0.50; [PATCH] Extend Gnus summary highlight faces by default

[Lars Ingebrigtsen]

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

> Mmm, somehow I failed to include a couple of face names in the ChangeLog
> entry…  I'm fairly certain I used C-x 4 a from a vc-diff buffer?
>
> Sorry about that 😕  I'll be sure to triple-check the message next time.

And I missed it too.  :-/  Oh, well, not a major deal...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no