* bug#56049: [PATCH] Fix invalid defcustom :group when :predicate is used
@ 2022-06-18 5:10 Richard Hansen
2022-06-18 12:11 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Richard Hansen @ 2022-06-18 5:10 UTC (permalink / raw)
To: 56049; +Cc: larsi
[-- Attachment #1.1.1: Type: text/plain, Size: 322 bytes --]
X-Debbugs-CC: larsi@gnus.org
The attached patch fixes a bug in Emacs 28:
Fix invalid defcustom :group when :predicate is used
* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Fix
invalid `:group' argument for the `-modes' defcustom that is created
when `:predicate' is used.
[-- Attachment #1.1.2: 0001-Fix-invalid-defcustom-group-when-predicate-is-used.patch --]
[-- Type: text/x-patch, Size: 945 bytes --]
From fbb1ad3d143aa335534527118db3115383be9fb3 Mon Sep 17 00:00:00 2001
From: Richard Hansen <rhansen@rhansen.org>
Date: Sat, 18 Jun 2022 00:41:04 -0400
Subject: [PATCH] Fix invalid defcustom :group when :predicate is used
* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Fix
invalid `:group' argument for the `-modes' defcustom that is created
when `:predicate' is used.
---
lisp/emacs-lisp/easy-mmode.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
index 1d93fe4801..df37903503 100644
--- a/lisp/emacs-lisp/easy-mmode.el
+++ b/lisp/emacs-lisp/easy-mmode.el
@@ -555,7 +555,7 @@ define-globalized-minor-mode
list."
mode)
:type '(repeat sexp)
- :group ,group))
+ ,@group))
;; Autoloading define-globalized-minor-mode autoloads everything
;; up-to-here.
--
2.36.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#56049: [PATCH] Fix invalid defcustom :group when :predicate is used
2022-06-18 5:10 bug#56049: [PATCH] Fix invalid defcustom :group when :predicate is used Richard Hansen
@ 2022-06-18 12:11 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-18 12:11 UTC (permalink / raw)
To: Richard Hansen; +Cc: 56049
Richard Hansen <rhansen@rhansen.org> writes:
> The attached patch fixes a bug in Emacs 28:
>
> Fix invalid defcustom :group when :predicate is used
>
> * lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Fix
> invalid `:group' argument for the `-modes' defcustom that is created
> when `:predicate' is used.
Thanks; pushed to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-18 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-18 5:10 bug#56049: [PATCH] Fix invalid defcustom :group when :predicate is used Richard Hansen
2022-06-18 12:11 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).