* bug#65713: compilation-next-error says: Moved past last error, even when none
@ 2023-09-03 8:19 Dan Jacobson
2023-09-03 8:45 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Dan Jacobson @ 2023-09-03 8:19 UTC (permalink / raw)
To: 65713
compilation-next-error says: Moved past last error
even if there was no errors that it found.
So it should differentiate such cases.
M-x compile
make
make: *** No targets specified and no makefile found. Stop.
OK, there was no error, so instead of "Moved past last error" it should
say "Didn't find any errors" when asked.
emacs-version "29.1"
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#65713: compilation-next-error says: Moved past last error, even when none
2023-09-03 8:19 bug#65713: compilation-next-error says: Moved past last error, even when none Dan Jacobson
@ 2023-09-03 8:45 ` Eli Zaretskii
2023-09-03 9:00 ` Stefan Kangas
2023-09-04 22:57 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 2 replies; 10+ messages in thread
From: Eli Zaretskii @ 2023-09-03 8:45 UTC (permalink / raw)
To: Dan Jacobson; +Cc: 65713
> From: Dan Jacobson <jidanni@jidanni.org>
> Date: Sun, 03 Sep 2023 03:19:30 -0500
>
> compilation-next-error says: Moved past last error
> even if there was no errors that it found.
> So it should differentiate such cases.
> M-x compile
>
> make
> make: *** No targets specified and no makefile found. Stop.
>
> OK, there was no error, so instead of "Moved past last error" it should
> say "Didn't find any errors" when asked.
FWIW, I don't see any need for such a feature. "Moved past the last
error" is correct even if there are no errors, and complicating the
code for such hair-splitting is not justified, IMO.
So my vote is to close this as "wontfix".
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#65713: compilation-next-error says: Moved past last error, even when none
2023-09-03 8:45 ` Eli Zaretskii
@ 2023-09-03 9:00 ` Stefan Kangas
2023-09-03 9:07 ` Eli Zaretskii
2023-09-04 22:57 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 10+ messages in thread
From: Stefan Kangas @ 2023-09-03 9:00 UTC (permalink / raw)
To: Eli Zaretskii, Dan Jacobson; +Cc: 65713
Eli Zaretskii <eliz@gnu.org> writes:
>> OK, there was no error, so instead of "Moved past last error" it should
>> say "Didn't find any errors" when asked.
>
> FWIW, I don't see any need for such a feature. "Moved past the last
> error" is correct even if there are no errors, and complicating the
> code for such hair-splitting is not justified, IMO.
The problem I see is that we're displaying a general message, when a
more specific one could have been displayed instead. I'm not against
fixing this minor blemish, if it can be done in a clean way.
This bug report would be more compelling if it came with a patch, of
course.
> So my vote is to close this as "wontfix".
That's also an option, yes.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#65713: compilation-next-error says: Moved past last error, even when none
2023-09-03 9:00 ` Stefan Kangas
@ 2023-09-03 9:07 ` Eli Zaretskii
2023-09-03 14:07 ` Dan Jacobson
2023-09-03 14:40 ` Stefan Kangas
0 siblings, 2 replies; 10+ messages in thread
From: Eli Zaretskii @ 2023-09-03 9:07 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 65713, jidanni
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 3 Sep 2023 02:00:50 -0700
> Cc: 65713@debbugs.gnu.org
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> OK, there was no error, so instead of "Moved past last error" it should
> >> say "Didn't find any errors" when asked.
> >
> > FWIW, I don't see any need for such a feature. "Moved past the last
> > error" is correct even if there are no errors, and complicating the
> > code for such hair-splitting is not justified, IMO.
>
> The problem I see is that we're displaying a general message, when a
> more specific one could have been displayed instead. I'm not against
> fixing this minor blemish, if it can be done in a clean way.
Would it be enough to say something like
Moved past last error, if any
?
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#65713: compilation-next-error says: Moved past last error, even when none
2023-09-03 9:07 ` Eli Zaretskii
@ 2023-09-03 14:07 ` Dan Jacobson
2023-09-03 14:40 ` Stefan Kangas
1 sibling, 0 replies; 10+ messages in thread
From: Dan Jacobson @ 2023-09-03 14:07 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 65713, Stefan Kangas
>>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:
EZ> Would it be enough to say something like
EZ> Moved past last error, if any
OK, that would make me feel better.
That way at least I wouldn't go on wild goose chases looking for the
error I missed.
Actually I still would, but at least I wouldn't feel as bad when I
didn't find any.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#65713: compilation-next-error says: Moved past last error, even when none
2023-09-03 9:07 ` Eli Zaretskii
2023-09-03 14:07 ` Dan Jacobson
@ 2023-09-03 14:40 ` Stefan Kangas
1 sibling, 0 replies; 10+ messages in thread
From: Stefan Kangas @ 2023-09-03 14:40 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 65713, jidanni
Eli Zaretskii <eliz@gnu.org> writes:
> Would it be enough to say something like
>
> Moved past last error, if any
>
> ?
That has the problem that it's less specific than it could be. So I'm
not sure it would be enough of an improvement to justify the change.
Perhaps it's better to do nothing here.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#65713: compilation-next-error says: Moved past last error, even when none
2023-09-03 8:45 ` Eli Zaretskii
2023-09-03 9:00 ` Stefan Kangas
@ 2023-09-04 22:57 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 11:15 ` Eli Zaretskii
1 sibling, 1 reply; 10+ messages in thread
From: Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-09-04 22:57 UTC (permalink / raw)
To: Eli Zaretskii, Dan Jacobson; +Cc: 65713
Eli Zaretskii <eliz@gnu.org> writes:
> FWIW, I don't see any need for such a
> feature.
For what is worth, as a long-term heavy user
of the Compilation mode, I find the message
confusing as well, on a daily basis.
> "Moved past the last error" is correct even
> if there are no errors, [...]
Is it really correct to say that the point
"moved" when it did not move?
Rudy
--
"The introduction of suitable abstractions is our only mental aid to
organize and master complexity."
-- Edsger Wybe Dijkstra, 1930-2002
Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#65713: compilation-next-error says: Moved past last error, even when none
2023-09-04 22:57 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-09-05 11:15 ` Eli Zaretskii
2023-10-03 20:18 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2023-09-05 11:15 UTC (permalink / raw)
To: Rudolf Adamkovič; +Cc: 65713, jidanni
> From: Rudolf Adamkovič <salutis@me.com>
> Cc: 65713@debbugs.gnu.org
> Date: Tue, 05 Sep 2023 00:57:07 +0200
>
> > "Moved past the last error" is correct even
> > if there are no errors, [...]
>
> Is it really correct to say that the point
> "moved" when it did not move?
Would it help to remove the "Moved" part?
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#65713: compilation-next-error says: Moved past last error, even when none
2023-09-05 11:15 ` Eli Zaretskii
@ 2023-10-03 20:18 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 8:02 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-10-03 20:18 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 65713, jidanni
Eli Zaretskii <eliz@gnu.org> writes:
>> Is it really correct to say that the point
>> "moved" when it did not move?
>
> Would it help to remove the "Moved" part?
That sounds like a good idea.
Rudy
--
"I love deadlines. I love the whooshing noise they make as they go by."
-- Douglas Adams, The Salmon of Doubt, 2002
Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-10-05 8:02 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-03 8:19 bug#65713: compilation-next-error says: Moved past last error, even when none Dan Jacobson
2023-09-03 8:45 ` Eli Zaretskii
2023-09-03 9:00 ` Stefan Kangas
2023-09-03 9:07 ` Eli Zaretskii
2023-09-03 14:07 ` Dan Jacobson
2023-09-03 14:40 ` Stefan Kangas
2023-09-04 22:57 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 11:15 ` Eli Zaretskii
2023-10-03 20:18 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 8:02 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).