From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: German Pacenza <germanp82@hotmail.com>,
58396@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#58396: 29.0.50; Optimization failure for add-to-list
Date: Tue, 26 Sep 2023 22:30:47 +0200 [thread overview]
Message-ID: <87o7hod6dk.fsf@sappc2.fritz.box> (raw)
In-Reply-To: <87fsfte2hf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 12 Oct 2022 12:54:36 +0200")
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> Yes (plus silence the messages plus avoid compiler macros).
>
> Any chance that... someone... will do that? 😇
>
Hit this issue today. How about the attached patch, which seems to fix
it? I hope I understood Stefan's directions correctly.
BTW, bug#60081 could also be merged with this one.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Silence-macro-expansion-during-completion-at-point.patch --]
[-- Type: text/x-diff, Size: 2112 bytes --]
From 83387466cfb7fe859b227fb00148ee7f6cd288a5 Mon Sep 17 00:00:00 2001
From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Date: Tue, 26 Sep 2023 22:26:15 +0200
Subject: [PATCH] Silence macro expansion during completion-at-point
* lisp/progmodes/elisp-mode.el (elisp--local-variables): Silence
messages. Avoid compiler macros. Suppress all errors during macro
expansion. (Bug#58396)
---
lisp/progmodes/elisp-mode.el | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index bd3916ce108..809df64a536 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -445,11 +445,23 @@ elisp--local-variables
(condition-case nil
(apply expander form args)
(error form))))
+ (macroexp--c-m-advice (lambda (_handler form) form))
+ ;; Avoid any macro expansion errors when attempting
+ ;; completion at point (bug#58148). As Stefan suggested
+ ;; there: Silence messages [1], avoid compiler macros
+ ;; [2], and suppress all errors [3].
(sexp
(unwind-protect
- (let ((warning-minimum-log-level :emergency))
+ (let ((inhibit-message t) ;[1]
+ (warning-minimum-log-level :emergency))
(advice-add 'macroexpand :around macroexpand-advice)
- (macroexpand-all sexp))
+ (advice-add 'macroexp--compiler-macro :override
+ macroexp--c-m-advice) ;[2]
+ (condition-case nil
+ (macroexpand-all sexp)
+ (t sexp))) ;[3]
+ (advice-remove 'macroexp--compiler-macro
+ macroexp--c-m-advice)
(advice-remove 'macroexpand macroexpand-advice)))
(vars (elisp--local-variables-1 nil sexp)))
(delq nil
--
2.30.2
next prev parent reply other threads:[~2023-09-26 20:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 16:20 bug#58396: 29.0.50; Optimization failure for add-to-list German Pacenza
2022-10-10 8:25 ` Lars Ingebrigtsen
2022-10-10 8:34 ` Lars Ingebrigtsen
2022-10-10 14:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-11 0:28 ` Lars Ingebrigtsen
2022-10-11 1:53 ` Drew Adams
2022-10-11 3:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-11 18:27 ` Lars Ingebrigtsen
2022-10-11 19:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-12 10:54 ` Lars Ingebrigtsen
2023-09-26 20:30 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-26 21:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26 21:48 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26 22:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 10:39 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 13:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 18:44 ` bug#58396: bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 18:07 ` bug#60081: " Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-03 19:04 ` bug#58396: 29.0.50; Optimization failure for add-to-list Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 14:26 ` Eli Zaretskii
2023-09-30 18:51 ` bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 18:54 ` Eli Zaretskii
2023-09-30 22:03 ` bug#58396: 29.0.50; Optimization failure for add-to-list Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7hod6dk.fsf@sappc2.fritz.box \
--to=bug-gnu-emacs@gnu.org \
--cc=58396@debbugs.gnu.org \
--cc=germanp82@hotmail.com \
--cc=jschmidt4gnu@vodafonemail.de \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).