unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: germanp82@hotmail.com, 58396@debbugs.gnu.org, larsi@gnus.org,
	monnier@iro.umontreal.ca, 58148@debbugs.gnu.org
Subject: bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro
Date: Sat, 30 Sep 2023 20:51:25 +0200	[thread overview]
Message-ID: <8734yvbiky.fsf_-_@sappc2.fritz.box> (raw)
In-Reply-To: <83jzs7aga5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Sep 2023 17:26:26 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> Most of this comment should be in the commit log message, I think, and
> the [1] and [3] markers should be replaced with text telling what that
> does.  Otherwise, the first patch is okay for the emacs-29 branch.

Updated the patch accordingly and sent it on that other branch of this
thread, please review.  However, I removed the [1] and [3] markers
without replacement: I don't think that there is much need to separately
comment on a `condition-case' or a let-binding of `inhibit-message'.

> Regarding the second patch: if Stefan Monnier and Stefan Kangas are
> okay with it, so am I.

Does that mean that I should explicitly draw Stefan Kangas' attention to
this bug?  Or would he notice somehow otherwise?

Thanks.





  reply	other threads:[~2023-09-30 18:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 16:20 bug#58396: 29.0.50; Optimization failure for add-to-list German Pacenza
2022-10-10  8:25 ` Lars Ingebrigtsen
2022-10-10  8:34   ` Lars Ingebrigtsen
2022-10-10 14:59     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-11  0:28       ` Lars Ingebrigtsen
2022-10-11  1:53         ` Drew Adams
2022-10-11  3:46         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-11 18:27           ` Lars Ingebrigtsen
2022-10-11 19:13             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-12 10:54               ` Lars Ingebrigtsen
2023-09-26 20:30                 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26 21:32                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26 21:48                     ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26 22:06                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 10:39                         ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 13:56                           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 18:44                             ` bug#58396: bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 18:07                               ` bug#60081: " Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-03 19:04                             ` bug#58396: 29.0.50; Optimization failure for add-to-list Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 14:26                           ` Eli Zaretskii
2023-09-30 18:51                             ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-30 18:54                               ` bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro Eli Zaretskii
2023-09-30 22:03                             ` bug#58396: 29.0.50; Optimization failure for add-to-list Stefan Kangas
  -- strict thread matches above, loose matches on Subject: below --
2022-09-28 18:03 bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro Juri Linkov
2022-09-28 18:24 ` Lars Ingebrigtsen
2022-09-28 19:34   ` Juri Linkov
2022-09-29 10:34     ` Lars Ingebrigtsen
2022-09-29 15:30       ` Juri Linkov
2022-09-30 12:37         ` Lars Ingebrigtsen
2022-10-01 19:17           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734yvbiky.fsf_-_@sappc2.fritz.box \
    --to=bug-gnu-emacs@gnu.org \
    --cc=58148@debbugs.gnu.org \
    --cc=58396@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=germanp82@hotmail.com \
    --cc=jschmidt4gnu@vodafonemail.de \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).