From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 69237-done@debbugs.gnu.org
Subject: bug#69237: 30.0.50; Toggle password visibility
Date: Sun, 25 Feb 2024 10:50:56 +0000 [thread overview]
Message-ID: <87o7c4yfzj.fsf@gmail.com> (raw)
In-Reply-To: <87frxgvrh4.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Feb 2024 10:11:03 +0100")
Michael Albinus <michael.albinus@gmx.de> writes:
>>> There are not so many comments on the keybindings. I guess this is
>>> because only few people read the bug-gnu-emacs ML. Let's install this on
>>> master, and see who hollers :-)
>>
>> Works for me 😊 Thanks for adding icons.el support!
>
> No further comments, so I have pushed this to master. Closing th bug.
Yay! Couple of belated comments, with the benefit of caffeine:
* Should we keep the double hyphen in "read-passwd--toggle-visibility"?
Feeling like it connotes "Emacs internals" somewhat, and wondering if
it's appropriate for interactive commands since they are "user-facing",
and users might feel discouraged from remapping "internal-looking"
commands.
* For the 'text icon variants, should we follow outline.el's example and
use full verbs, like " reveal " and " conceal "?
(Don't want to be a pest; I can take care of the follow-up patch if we
agree with these tweaks, haven't done so yet because EBATTERY)
next prev parent reply other threads:[~2024-02-25 10:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 13:33 bug#69237: 30.0.50; Toggle password visibility Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-18 19:00 ` Eli Zaretskii
2024-02-18 20:04 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-19 12:21 ` Eli Zaretskii
2024-02-19 15:54 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-19 16:48 ` Eli Zaretskii
2024-02-19 17:08 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-22 22:30 ` Kévin Le Gouguec
2024-02-23 15:43 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-23 16:56 ` Kévin Le Gouguec
2024-02-25 9:11 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 10:50 ` Kévin Le Gouguec [this message]
2024-02-25 11:25 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 13:34 ` Kévin Le Gouguec
2024-02-25 14:09 ` Eli Zaretskii
2024-02-25 14:38 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 14:42 ` Eli Zaretskii
2024-02-25 14:48 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 15:27 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7c4yfzj.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=69237-done@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).