From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#69237: 30.0.50; Toggle password visibility Date: Sun, 25 Feb 2024 10:50:56 +0000 Message-ID: <87o7c4yfzj.fsf@gmail.com> References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8539"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69237-done@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 25 11:52:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1reC7v-0001wC-4D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Feb 2024 11:52:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reC7b-0001jw-I4; Sun, 25 Feb 2024 05:52:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reC7Z-0001jk-Nl for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 05:52:37 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reC7Z-0000Uy-Fo for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 05:52:37 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1reC7x-0004Hh-TZ for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 05:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Feb 2024 10:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69237 X-GNU-PR-Package: emacs Original-Received: via spool by 69237-done@debbugs.gnu.org id=D69237.170885836916432 (code D ref 69237); Sun, 25 Feb 2024 10:53:01 +0000 Original-Received: (at 69237-done) by debbugs.gnu.org; 25 Feb 2024 10:52:49 +0000 Original-Received: from localhost ([127.0.0.1]:35091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reC7l-0004Gy-0o for submit@debbugs.gnu.org; Sun, 25 Feb 2024 05:52:49 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:49313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reC7i-0004GV-HJ for 69237-done@debbugs.gnu.org; Sun, 25 Feb 2024 05:52:47 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33d8739ddd4so1737963f8f.2 for <69237-done@debbugs.gnu.org>; Sun, 25 Feb 2024 02:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708858275; x=1709463075; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i6DhtaMtkPhfOPU5YJQskzRlSVVJj5vyz9/FhHPM8bE=; b=cVppi988OJPvgBbxuBSU7FdQg1gaKSJ0gt+UAsCEzDcHkw6XtQv2i1GEJeuvgc0QXe LXKL0jqFSmjnEffSi6cLVPRzJFsse48R6LHMZygTwR08+UPLmIvODswRRLkOOXxOlFx9 WwnVMzD/G1QTRL+gprnzVHMz9J63OGNFw0/WRWgpfh12Sd2edb1fv2I9PHhf/sN7DZc7 CiLfctgVnWjZmhLLFFQe7rbXiDAhFXZPP155FSB91sQJLvBqa63bFc4gMDJjkJctOnB+ O7xhYkGG5LZ/T/kB5m36NlRynZNgSXS6Mcb9d6WD6Je7VXhn+z0udtyOFY1jBqOFNzT1 JnYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708858275; x=1709463075; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i6DhtaMtkPhfOPU5YJQskzRlSVVJj5vyz9/FhHPM8bE=; b=sZPOKlKUlvTIf+hUau/bxsDnWl01okezQ/tOpK+kojvuDEpQfOGdcdYJbjvehwx/+c gP3+IaPoAy2NTToONKVJ8x33PcA1r9WPoO6ZB6U+wFPe9zr+XzR1gJK7HIGU3qLbaz5i Qk7PoZ2NK76zT6/Gb+H4/KW/pm8a3tbC85bFqHpR0kWI20hpR6CHn/PxdvTzHe8MLKdO qmkRB/Y8v9/jlOHxHD8cyqn7MsL/ivjXJ/9q+w/5w5fa4Pu2wyN3xSnthjYn3CiUtpX7 7uKofzz6JSBL6TlxrnWwkFebiwL2rhsXawkr1p06advOkXNLRxhZtOtCX9+UkMH4/soJ zdPA== X-Gm-Message-State: AOJu0YyyZpU71ODCcl7otWAT0aFcua77d4r29aD1JyToNBEmOli38Oo0 pfHFPDpEqz+o4XUJAMHOH1wAd2w30i97PWOhSXd6EjnEw70YoqRIVH3cxLxBTSCZDA== X-Google-Smtp-Source: AGHT+IErd9Dr0gXUn27pgQaX5Gl5LzpmCRprq5rapkU9TdxHK5bdMKO/qpBhe/qbk03+5Dc1l9GVyQ== X-Received: by 2002:a5d:500b:0:b0:33d:3fe6:720e with SMTP id e11-20020a5d500b000000b0033d3fe6720emr2511174wrt.17.1708858275440; Sun, 25 Feb 2024 02:51:15 -0800 (PST) Original-Received: from hirondell (ip-185-104-136-49.ptr.icomera.net. [185.104.136.49]) by smtp.gmail.com with ESMTPSA id bs23-20020a056000071700b0033d5f5571b4sm4836721wrb.44.2024.02.25.02.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 02:51:14 -0800 (PST) In-Reply-To: <87frxgvrh4.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Feb 2024 10:11:03 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280610 Archived-At: Michael Albinus writes: >>> There are not so many comments on the keybindings. I guess this is >>> because only few people read the bug-gnu-emacs ML. Let's install this on >>> master, and see who hollers :-) >> >> Works for me =F0=9F=98=8A Thanks for adding icons.el support! > > No further comments, so I have pushed this to master. Closing th bug. Yay! Couple of belated comments, with the benefit of caffeine: * Should we keep the double hyphen in "read-passwd--toggle-visibility"? Feeling like it connotes "Emacs internals" somewhat, and wondering if it's appropriate for interactive commands since they are "user-facing", and users might feel discouraged from remapping "internal-looking" commands. * For the 'text icon variants, should we follow outline.el's example and use full verbs, like " reveal " and " conceal "? (Don't want to be a pest; I can take care of the follow-up patch if we agree with these tweaks, haven't done so yet because EBATTERY)