bug#4250: 23.1; bookmark.el should raise reasonable error for empty filename entry

bug#4250: 23.1; bookmark.el should raise reasonable error for empty filename entry

[Drew Adams]

I have code that allows for bookmarks that have no filename, that is,
where the `filename' entry in `bookmark-alist' is `(filename)'.
 
It would be ideal and most reasonable if vanilla Emacs simply ignored
such a bookmark - tolerance. More generally, it would be great if it would
tolerate any bookmark in `bookmark-alist' that it doesn't recognize.
 
If that is not something you agree about, then at least it should
raise a reasonable error - not just "wrong-type-arg stringp, nil",
whenever a "malformed" bookmark is encountered.
 
The code in `bookmark-default-handler' is an example of the problem.
The local variable `file' is bound to (bookmark-get-filename bmk) -
which returns nil if there is no `filename' entry or the `filename'
entry is `(filename)'.
 
The code then simply calls (file-exists-p nil), via
(bookmark-file-or-variation-thereof nil), raising the wrong-type-arg
error.
 
In the alternative `if' branch, the code calls (find-file-noselect
nil), which has the same problem.
 
In general, it would be great if places where `bookmark-get-filename'
is called tested the result and treated nil by raising a
bookmark-level error.
 
As I said, it would be even better if the bookmark.el code could be
made tolerant of any bookmark whose format it does not
recognize.

bookmark.el already allows for applications and users to add new,
addtional entries. The problem is that it doesn't allow for
unexpected forms of the entries it predefines. It would be nice if it
were tolerant, and simply ignored any such bookmark (no error).
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 

bug#4250: 23.1; bookmark.el should raise reasonable error for empty filename entry

[Chong Yidong]

Hi Karl,

Could you take a look at bug#4250 for the bookmark package?  Thanks.

(Drew Adams has filed a few other bookmark.el bugs in the bug tracker,
and if you could look at them as well, that would be good.  Thanks.)

bug#4250: 23.1; bookmark.el should raise reasonable error for empty filename entry

[Karl Fogel]

Chong Yidong <cyd@stupidchicken.com> writes:
> Hi Karl,
>
> Could you take a look at bug#4250 for the bookmark package?  Thanks.
>
> (Drew Adams has filed a few other bookmark.el bugs in the bug tracker,
> and if you could look at them as well, that would be good.  Thanks.)

Yes, I will take a look.  Thank you for bringing it to my attention.

-Karl

bug#4250: 23.1; bookmark.el should raise reasonable error for empty filename entry

[Drew Adams]

> > Could you take a look at bug#4250 for the bookmark package?  Thanks.
> >
> > (Drew Adams has filed a few other bookmark.el bugs in the 
> > bug tracker, and if you could look at them as well, that
> > would be good.  Thanks.)
> 
> Yes, I will take a look.  Thank you for bringing it to my attention.

Thanks. When you can, please take a look also at the bookmark.el bugs filed by
Thierry Volpiatto.

Thx - Drew