unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 'Lars Magne Ingebrigtsen' <larsi@gnus.org>, 9361@debbugs.gnu.org
Subject: bug#9361: 24.0.50; default value of `dired-do-chmod'
Date: Mon, 12 Sep 2011 14:49:23 +0300	[thread overview]
Message-ID: <87mxea55u8.fsf@mail.jurta.org> (raw)
In-Reply-To: <87bouqlptn.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 11 Sep 2011 17:41:24 -0400")

> I think there's a problem here, indeed.  It's a bad idea to take an
> empty input to mean a certain default permission---especially when that
> default permission is not displayed in the prompt.
>
> The following patch makes dired-do-chmod demand a non-empty input.  The
> precomputed permission is still available in the M-n `future history'.

There are other demands that dired commands should not use `read-string'
that returns the default value for an empty input.  Please see
http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg01200.html

So we should either change `read-string' (backward-incompatible change)
or to change `dired-mark-read-string' not to use `read-string'.

Another solution is to add a new global variable that changes the default
behavior of `read-string' and let-bind it in `dired-mark-read-string'.

> +     (while (equal result "")
> +       (setq result
> + 	    (read-from-minibuffer prompt nil nil
> + 				  nil nil default)))

I think it should tell the user what's wrong, like `read-number' does
with "Please enter a number."

Too bad that currently semantically similar functions
`read-string' and `read-number' differ significantly
WRT handling an empty input and default values.





  reply	other threads:[~2011-09-12 11:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 16:10 bug#9361: 24.0.50; default value of `dired-do-chmod' Drew Adams
2011-08-24 18:45 ` Juri Linkov
2011-09-11  2:23   ` Lars Magne Ingebrigtsen
2011-09-11 15:00     ` Drew Adams
2011-09-11 21:41       ` Chong Yidong
2011-09-12 11:49         ` Juri Linkov [this message]
2011-09-12 20:47           ` Chong Yidong
2011-09-14 11:20             ` Juri Linkov
2011-09-14 15:07               ` Chong Yidong
2011-09-14 15:54                 ` Juri Linkov
2011-09-12 11:39       ` Juri Linkov
2011-09-12 14:45         ` Drew Adams
2012-01-26 16:27       ` Drew Adams
2012-01-27  1:38         ` Juri Linkov
2012-01-27  3:04           ` Drew Adams
2012-01-27  7:24         ` Chong Yidong
2012-01-27 12:09           ` Juri Linkov
2012-01-27 16:58             ` Drew Adams
2012-01-27 15:42           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxea55u8.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=9361@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).