unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 9361@debbugs.gnu.org
Subject: bug#9361: 24.0.50; default value of `dired-do-chmod'
Date: Wed, 14 Sep 2011 14:20:58 +0300	[thread overview]
Message-ID: <874o0fv085.fsf@mail.jurta.org> (raw)
In-Reply-To: <877h5d1o9b.fsf@stupidchicken.com> (Chong Yidong's message of "Mon, 12 Sep 2011 16:47:44 -0400")

> I fixed up `dired-mark-read-string'; that's much safer, since there are
> only three callers to worry about.

Thank you, it's now safer.

There are still two problems:

In `dired-do-chmod':

>        (modes (dired-mark-read-string
>                "Change mode of %s to: "
>                ;; Insert initial input if there's only one file.
>                (unless (cadr files) default)
>                'chmod arg files default))

Please don't insert the default value as initial input.
Most of the time, users type short symbolic modes that
add/remove permissions on one user part such as "a=rw" or "go-w".
It would be annoying for them to delete initial input
before typing symbolic modes.

Another problem in `dired-mark-read-string':

> STANDARD-VALUE, if non-nil, should be a \"standard\" value or
> list of such values, available via history commands.

STANDARD-VALUE is non-standard terminology.  According to
`read-from-minibuffer' it's named DEFAULT-VALUE.





  reply	other threads:[~2011-09-14 11:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 16:10 bug#9361: 24.0.50; default value of `dired-do-chmod' Drew Adams
2011-08-24 18:45 ` Juri Linkov
2011-09-11  2:23   ` Lars Magne Ingebrigtsen
2011-09-11 15:00     ` Drew Adams
2011-09-11 21:41       ` Chong Yidong
2011-09-12 11:49         ` Juri Linkov
2011-09-12 20:47           ` Chong Yidong
2011-09-14 11:20             ` Juri Linkov [this message]
2011-09-14 15:07               ` Chong Yidong
2011-09-14 15:54                 ` Juri Linkov
2011-09-12 11:39       ` Juri Linkov
2011-09-12 14:45         ` Drew Adams
2012-01-26 16:27       ` Drew Adams
2012-01-27  1:38         ` Juri Linkov
2012-01-27  3:04           ` Drew Adams
2012-01-27  7:24         ` Chong Yidong
2012-01-27 12:09           ` Juri Linkov
2012-01-27 16:58             ` Drew Adams
2012-01-27 15:42           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874o0fv085.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=9361@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).