From: Michael Heerdegen <michael_heerdegen@web.de>
To: 14317@debbugs.gnu.org
Subject: bug#14317: 24.3.50; nadvice.el: named advices not upgradable
Date: Tue, 30 Apr 2013 01:42:14 +0200 [thread overview]
Message-ID: <87mwsgx5t5.fsf@web.de> (raw)
Hi Stefan,
if you have some code adding advices that can be identified (i.e.,
adding named advices or fbound symbols, not anonymous functions),
and you change this code defining the advice and re-evaluate, the change
doesn't take effect (in contrast to the behavior of advice.el).
We currently use this:
--8<---------------cut here---------------start------------->8---
(defun advice--add-function (where ref function props)
(unless (advice--member-p function (cdr (assq 'name props))
(gv-deref ref))
(setf (gv-deref ref)
(advice--make where function (gv-deref ref) props))))
--8<---------------cut here---------------end--------------->8---
but as a user, I would suspect something like
--8<---------------cut here---------------start------------->8---
(defun advice--add-function (where ref function props)
(when (advice--member-p function (cdr (assq 'name props))
(gv-deref ref))
(advice--remove-function .........))
(setf (gv-deref ref)
(advice--make where function (gv-deref ref) props)))
--8<---------------cut here---------------end--------------->8---
i.e., replacing the old code, instead of doing nothing.
Is the current behavior intended? If not, can we change it?
Regards,
Michael.
next reply other threads:[~2013-04-29 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 23:42 Michael Heerdegen [this message]
2013-05-03 1:20 ` bug#14317: 24.3.50; nadvice.el: named advices not upgradable Michael Heerdegen
2013-05-05 5:49 ` Stefan Monnier
2013-05-06 15:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwsgx5t5.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=14317@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).