From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#14317: 24.3.50; nadvice.el: named advices not upgradable Date: Tue, 30 Apr 2013 01:42:14 +0200 Message-ID: <87mwsgx5t5.fsf@web.de> Reply-To: michael_heerdegen@web.de NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367278971 27443 80.91.229.3 (29 Apr 2013 23:42:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Apr 2013 23:42:51 +0000 (UTC) To: 14317@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 30 01:42:49 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UWxib-0007M4-6Z for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2013 01:42:49 +0200 Original-Received: from localhost ([::1]:35103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWxia-0006OW-Pf for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2013 19:42:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWxiW-0006OK-8E for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 19:42:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWxiV-0002MS-0v for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 19:42:44 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWxiU-0002MO-Tq for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 19:42:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UWxio-00051b-JN for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 19:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2013 23:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.136727897419287 (code B ref -1); Mon, 29 Apr 2013 23:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Apr 2013 23:42:54 +0000 Original-Received: from localhost ([127.0.0.1]:51123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWxig-000511-1i for submit@debbugs.gnu.org; Mon, 29 Apr 2013 19:42:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42325) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWxie-00050o-FJ for submit@debbugs.gnu.org; Mon, 29 Apr 2013 19:42:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWxiJ-0002LR-Lu for submit@debbugs.gnu.org; Mon, 29 Apr 2013 19:42:32 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:44678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWxiJ-0002LN-Im for submit@debbugs.gnu.org; Mon, 29 Apr 2013 19:42:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWxiI-0006Nv-NN for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 19:42:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWxiH-0002LB-PI for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 19:42:30 -0400 Original-Received: from mout.web.de ([212.227.15.3]:52597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWxiH-0002L4-Fy for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 19:42:29 -0400 Original-Received: from drachen.dragon ([89.204.138.205]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0Lm4Z3-1V61Pm3CML-00aFji for ; Tue, 30 Apr 2013 01:42:28 +0200 X-Provags-ID: V02:K0:34xD7MeIn7KUWHvuPr/yRPge8XiyPhB2VHBApaOB8MM +4fWm7TxkpAsGqwqmFPzAir7pw8PNRVAQUKuzRAmyE5FWu7tAW Fne1+JPYQb7+LtOAw1HH0J7mrDPMIEhCSBUeU846ww7KdsbUXM n7suaG6XAaSvVuQnD8hurweoqGSX6khsRtGT4LYXsos6tSvuhE 4AQCpyk9Gw7Rm4/4eA0vEm/pbZSBoS1S4+KbT7Wv0g= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73837 Archived-At: Hi Stefan, if you have some code adding advices that can be identified (i.e., adding named advices or fbound symbols, not anonymous functions), and you change this code defining the advice and re-evaluate, the change doesn't take effect (in contrast to the behavior of advice.el). We currently use this: --8<---------------cut here---------------start------------->8--- (defun advice--add-function (where ref function props) (unless (advice--member-p function (cdr (assq 'name props)) (gv-deref ref)) (setf (gv-deref ref) (advice--make where function (gv-deref ref) props)))) --8<---------------cut here---------------end--------------->8--- but as a user, I would suspect something like --8<---------------cut here---------------start------------->8--- (defun advice--add-function (where ref function props) (when (advice--member-p function (cdr (assq 'name props)) (gv-deref ref)) (advice--remove-function .........)) (setf (gv-deref ref) (advice--make where function (gv-deref ref) props))) --8<---------------cut here---------------end--------------->8--- i.e., replacing the old code, instead of doing nothing. Is the current behavior intended? If not, can we change it? Regards, Michael.