From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 15651@debbugs.gnu.org
Subject: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?
Date: Fri, 29 Apr 2016 16:00:11 +0200 [thread overview]
Message-ID: <87mvoc7bx0.fsf@gnus.org> (raw)
In-Reply-To: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> (Drew Adams's message of "Sat, 19 Oct 2013 08:33:20 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> `menu-bar-select-buffer' is defined in `menu-bar.el'. It used to be
> used there as well, in function `menu-bar-update-buffers'.
>
> Now, the latter function uses `menu-bar-select-buffer-function' instead
> (which makes no use of `menu-bar-select-buffer'). The only place
> `menu-bar-select-buffer' is used now is in `msb.el'.
>
> Why not remove `menu-bar-select-buffer' or move it to `msb.el'?
Well, there may be third party usages of this very important function, I
guess?
(defun menu-bar-select-buffer ()
(interactive)
(switch-to-buffer last-command-event))
And it's unclear whether it's used in msb.el. The only mention is:
(defun msb--make-keymap-menu (raw-menu)
(let ((end 'menu-bar-select-buffer)
(mcount 0))
But it could be funcalled afterwards... the logic is unclear...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-04-29 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 15:33 bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? Drew Adams
2016-04-29 14:00 ` Lars Ingebrigtsen [this message]
2021-05-30 5:49 ` Lars Ingebrigtsen
2021-05-30 8:47 ` Eli Zaretskii
2021-05-30 9:37 ` Lars Ingebrigtsen
2021-05-30 10:02 ` Eli Zaretskii
2021-05-31 5:31 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvoc7bx0.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=15651@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).