From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? Date: Fri, 29 Apr 2016 16:00:11 +0200 Message-ID: <87mvoc7bx0.fsf@gnus.org> References: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461938530 14390 80.91.229.3 (29 Apr 2016 14:02:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Apr 2016 14:02:10 +0000 (UTC) Cc: 15651@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 16:01:53 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aw8zQ-0000qO-W1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 16:01:53 +0200 Original-Received: from localhost ([::1]:54714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw8zN-0007ra-By for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 10:01:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw8yr-0006sA-AV for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 10:01:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw8yf-0003Xw-DW for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 10:01:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw8yf-0003XN-B2 for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 10:01:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aw8yb-0007Ks-Ub for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 10:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Apr 2016 14:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15651 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15651-submit@debbugs.gnu.org id=B15651.146193842626197 (code B ref 15651); Fri, 29 Apr 2016 14:01:01 +0000 Original-Received: (at 15651) by debbugs.gnu.org; 29 Apr 2016 14:00:26 +0000 Original-Received: from localhost ([127.0.0.1]:55331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw8y1-0006oB-Oy for submit@debbugs.gnu.org; Fri, 29 Apr 2016 10:00:25 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:55739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw8xz-0006lW-E4 for 15651@debbugs.gnu.org; Fri, 29 Apr 2016 10:00:23 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1aw8xo-0000gw-8m; Fri, 29 Apr 2016 16:00:22 +0200 In-Reply-To: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> (Drew Adams's message of "Sat, 19 Oct 2013 08:33:20 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117175 Archived-At: Drew Adams writes: > `menu-bar-select-buffer' is defined in `menu-bar.el'. It used to be > used there as well, in function `menu-bar-update-buffers'. > > Now, the latter function uses `menu-bar-select-buffer-function' instead > (which makes no use of `menu-bar-select-buffer'). The only place > `menu-bar-select-buffer' is used now is in `msb.el'. > > Why not remove `menu-bar-select-buffer' or move it to `msb.el'? Well, there may be third party usages of this very important function, I guess? (defun menu-bar-select-buffer () (interactive) (switch-to-buffer last-command-event)) And it's unclear whether it's used in msb.el. The only mention is: (defun msb--make-keymap-menu (raw-menu) (let ((end 'menu-bar-select-buffer) (mcount 0)) But it could be funcalled afterwards... the logic is unclear... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no