bug#44698: 27.1; dir-locals.el stay on file-local-variables-alist when using vc-mode

bug#44698: 27.1; dir-locals.el stay on file-local-variables-alist when using vc-mode

[Miguel Ángel Arruga Vivas]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]


Hi,

While using vc-mode, the dir-locals.el variables under 'nil' mode are
accumulated on file-local-variables-alist and they still apply after
exiting the scope of the file.  The attached script can be used to
reproduce it (Emacs 27.1, on GNU Guix
f6e031ab36fd99ad3536caabfdaefcc2b5f606a1).

It generates a temporary folder with two example git repositories, an
offending dir-locals.el[1], launches an emacs with -Q and the shows
the steps to follow:

1. Open p1/file and accept the .dir-locals.el variables.
2. Call vc-print-log
3. Check the file-local-variables-alist
4. Open p2/file (this one doesn't have .dir-locals.el).
5. Call vc-print-log again, the message is shown again.

Best regards,
Miguel

[1] It contains: ((nil . ((eval (message "Eval called")))))


[-- Attachment #2: repr.sh --]
[-- Type: application/x-sh, Size: 941 bytes --]

bug#44698: 27.1; dir-locals.el stay on file-local-variables-alist when using vc-mode

[Lars Ingebrigtsen]

Miguel Ángel Arruga Vivas <rosen644835@gmail.com> writes:

> While using vc-mode, the dir-locals.el variables under 'nil' mode are
> accumulated on file-local-variables-alist and they still apply after
> exiting the scope of the file.  The attached script can be used to
> reproduce it (Emacs 27.1, on GNU Guix
> f6e031ab36fd99ad3536caabfdaefcc2b5f606a1).
>
> It generates a temporary folder with two example git repositories, an
> offending dir-locals.el[1], launches an emacs with -Q and the shows
> the steps to follow:
>
> 1. Open p1/file and accept the .dir-locals.el variables.
> 2. Call vc-print-log
> 3. Check the file-local-variables-alist
> 4. Open p2/file (this one doesn't have .dir-locals.el).
> 5. Call vc-print-log again, the message is shown again.
>
> Best regards,
> Miguel
>
> [1] It contains: ((nil . ((eval (message "Eval called")))))

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

I tried to reproduce this with both Emacs 27.1 and Emacs 29, and I was
unable to -- in step 5), there's no message, and p2/file does not have
anything in file-local-variables-alist.

Are you still seeing this problem in recent Emacs versions?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44698: 27.1; dir-locals.el stay on file-local-variables-alist when using vc-mode

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I tried to reproduce this with both Emacs 27.1 and Emacs 29, and I was
> unable to -- in step 5), there's no message, and p2/file does not have
> anything in file-local-variables-alist.
>
> Are you still seeing this problem in recent Emacs versions?

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44698: 27.1; dir-locals.el stay on file-local-variables-alist when using vc-mode

[Maxim Cournoyer]

unarchive 44698
thanks

Hi,

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Miguel Ángel Arruga Vivas <rosen644835@gmail.com> writes:
>
>> While using vc-mode, the dir-locals.el variables under 'nil' mode are
>> accumulated on file-local-variables-alist and they still apply after
>> exiting the scope of the file.  The attached script can be used to
>> reproduce it (Emacs 27.1, on GNU Guix
>> f6e031ab36fd99ad3536caabfdaefcc2b5f606a1).
>>
>> It generates a temporary folder with two example git repositories, an
>> offending dir-locals.el[1], launches an emacs with -Q and the shows
>> the steps to follow:
>>
>> 1. Open p1/file and accept the .dir-locals.el variables.
>> 2. Call vc-print-log
>> 3. Check the file-local-variables-alist
>> 4. Open p2/file (this one doesn't have .dir-locals.el).
>> 5. Call vc-print-log again, the message is shown again.
>>
>> Best regards,
>> Miguel
>>
>> [1] It contains: ((nil . ((eval (message "Eval called")))))
>
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
>
> I tried to reproduce this with both Emacs 27.1 and Emacs 29, and I was
> unable to -- in step 5), there's no message, and p2/file does not have
> anything in file-local-variables-alist.
>
> Are you still seeing this problem in recent Emacs versions?

I tried the reproducer again on my side, and I can reproduce the issue
(that the file-local-variables-alist is leaked from p1/file to p2/file).

I'm thus reopening the ticket.

I used the current 'emacs' package from Guix to test, which is at
version 28.1.

Thanks!

Maxim

bug#44698: 27.1; dir-locals.el stay on file-local-variables-alist when using vc-mode

[Lars Ingebrigtsen]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> I tried the reproducer again on my side, and I can reproduce the issue
> (that the file-local-variables-alist is leaked from p1/file to p2/file).
>
> I'm thus reopening the ticket.
>
> I used the current 'emacs' package from Guix to test, which is at
> version 28.1.

Thanks -- it looks like you just unarchived the bug report, not reopened
it, so I've now done the latter.  (The debbugs interface is pretty
confusing.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no