From: Protesilaos Stavrou <info@protesilaos.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 44424@debbugs.gnu.org, Protesilaos Stavrou <info@protesilaos.com>
Subject: bug#44424: [PATCH] 28.0.50; Use bespoke face for commit message in vc-print-root-log
Date: Sat, 28 Nov 2020 20:56:32 +0200 [thread overview]
Message-ID: <87mtz148f3.fsf@protesilaos.com> (raw)
In-Reply-To: <ce3e4481-c79d-9d0d-1076-7b8c31b87042@yandex.ru> (Dmitry Gutov's message of "Sat, 28 Nov 2020 20:13:38 +0200")
On 2020-11-28, 20:13 +0200, Dmitry Gutov <dgutov@yandex.ru> wrote:
> On 03.11.2020 19:23, Protesilaos Stavrou wrote:
>> What do you think?
>
> I think the idea is good, but the change in the looks is a bit questionable.
>
> Can we do it without the grey background? It's kind of weird to see it
> surrounded by "unexpanded" log entries that use the default white
> background. And other windows that mostly use the white background.
>
> As we can see on the screenshots you posted yourself, the "before" one looks
> more uniform than the "after".
>
> If there are no alternative ideas on which colors to pick, we can just inherit
> from font-lock-comment-face, to retain the previous looks.
I think inheriting from font-lock-comment-face is the best option.
Should I send a patch or you can handle it?
--
Protesilaos Stavrou
protesilaos.com
next prev parent reply other threads:[~2020-11-28 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 17:23 bug#44424: [PATCH] 28.0.50; Use bespoke face for commit message in vc-print-root-log Protesilaos Stavrou
2020-11-09 16:14 ` Lars Ingebrigtsen
2020-11-28 18:13 ` Dmitry Gutov
2020-11-28 18:56 ` Protesilaos Stavrou [this message]
2020-11-28 19:07 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtz148f3.fsf@protesilaos.com \
--to=info@protesilaos.com \
--cc=44424@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).