From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#44424: [PATCH] 28.0.50; Use bespoke face for commit message in vc-print-root-log Date: Sat, 28 Nov 2020 20:56:32 +0200 Message-ID: <87mtz148f3.fsf@protesilaos.com> References: <87eela9wx9.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24777"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44424@debbugs.gnu.org, Protesilaos Stavrou To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 28 19:57:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kj5PB-0006IE-St for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Nov 2020 19:57:09 +0100 Original-Received: from localhost ([::1]:40534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kj5PA-00004u-Qi for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Nov 2020 13:57:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kj5P3-0008WO-W9 for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 13:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kj5P3-0001V3-OZ for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 13:57:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kj5P3-00070U-MA for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 13:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Nov 2020 18:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44424 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 44424-submit@debbugs.gnu.org id=B44424.160658980526912 (code B ref 44424); Sat, 28 Nov 2020 18:57:01 +0000 Original-Received: (at 44424) by debbugs.gnu.org; 28 Nov 2020 18:56:45 +0000 Original-Received: from localhost ([127.0.0.1]:49054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj5On-000700-Ft for submit@debbugs.gnu.org; Sat, 28 Nov 2020 13:56:45 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:55235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj5Ol-0006zl-6S for 44424@debbugs.gnu.org; Sat, 28 Nov 2020 13:56:44 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 94F83FF803; Sat, 28 Nov 2020 18:56:35 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Sat, 28 Nov 2020 20:13:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194497 Archived-At: On 2020-11-28, 20:13 +0200, Dmitry Gutov wrote: > On 03.11.2020 19:23, Protesilaos Stavrou wrote: >> What do you think? > > I think the idea is good, but the change in the looks is a bit questionable. > > Can we do it without the grey background? It's kind of weird to see it > surrounded by "unexpanded" log entries that use the default white > background. And other windows that mostly use the white background. > > As we can see on the screenshots you posted yourself, the "before" one looks > more uniform than the "after". > > If there are no alternative ideas on which colors to pick, we can just inherit > from font-lock-comment-face, to retain the previous looks. I think inheriting from font-lock-comment-face is the best option. Should I send a patch or you can handle it? -- Protesilaos Stavrou protesilaos.com