bug#17752: 24.4.50; Scrolling other window while skeleton reads input inserts garbage

bug#17752: 24.4.50; Scrolling other window while skeleton reads input inserts garbage

[Matthias]

1, Select a buffer whose content is not fully displayed in the 
selected window.   2. Choose a skeleton which read something from 
the minibuffer. Move
the cursor is at the bottom of the selected buffer. Insert the chosen
skeleton (for example python-skeleton-class).

3. When the minibuffer is selected and prompt for the skeleton's input,
scroll the initialy selected window (C-M-S-v).

4. Answer the prompt.

5. Garbage is inserted in the initially selected buffer because the point
has been moved in the middle of the skeleton insertion...

In GNU Emacs 24.4.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2)
 of 2014-05-27 on choubidou
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: fr_FR.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Python

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<return> <return> <tab> SPC SPC SPC SPC SPC SPC SPC 
SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC 
h e i g h t SPC s o SPC t <backspace> <backspace> <backspace> 
<backspace> <backspace> . <return> <return> <return> 
T h u s SPC w h i l e SPC e d i t i o <backspace> n 
g SPC t h e SPC m i n i p <backspace> b u f f e r SPC 
<backspace> , SPC i t SPC w i l <backspace> <backspace> 
<backspace> w <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> SPC a n d SPC h i t i n <backspace> 
<backspace> t i n g SPC M - C - v <backspace> w SPC 
<backspace> , SPC t h i s SPC w i n d o w SPC w i l 
l SPC s c r o l l . SPC I SPC <backspace> <backspace> 
<backspace> \ <return> I f SPC t h i s SPC i s SPC 
d o n e SPC w h e n e <backspace> SPC i n s e r t i 
n g SPC a SPC s k e l e t o n , SPC g a r b a g e SPC 
w i l l SPC b e SPC i n s e r t e d . . . <return> 
<return> " " " <return> <return> C-p C-p C-p C-p C-n 
<return> <return> L e t ' s SPC s e e : C-n C-n C-n 
C-c C-t c C-M-S-v C-M-S-v H e r e I s SPC <backspace> 
M y C l a s s N a m e <return> <return> M-x r e m <backspace> 
p o r t SPC b u g <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Can't guess python-indent-offset, using defaults: 4

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils skeleton python easymenu comint
ring ansi-color time-date tooltip electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
gfilenotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 81166 7501)
 (symbols 48 18657 0)
 (miscs 40 44 149)
 (strings 32 12404 4088)
 (string-bytes 1 352602)
 (vectors 16 10186)
 (vector-slots 8 388085 5267)
 (floats 8 72 430)
 (intervals 56 310 0)
 (buffers 960 11)
 (heap 1024 45579 1022))

bug#17752: 24.4.50; Scrolling other window while skeleton reads input inserts garbage

[Lars Ingebrigtsen]

Matthias <orontee@gmail.com> writes:

> 1, Select a buffer whose content is not fully displayed in the
> selected window.   2. Choose a skeleton which read something from the
> minibuffer. Move
> the cursor is at the bottom of the selected buffer. Insert the chosen
> skeleton (for example python-skeleton-class).
>
> 3. When the minibuffer is selected and prompt for the skeleton's input,
> scroll the initialy selected window (C-M-S-v).
>
> 4. Answer the prompt.
>
> 5. Garbage is inserted in the initially selected buffer because the point
> has been moved in the middle of the skeleton insertion...

(This bug report unfortunately got no response at the time.)

The recipe for reproduction is somewhat unclear.  For instance, how is
the skeleton chosen?

Could you provide a step-by-step recipe, starting from "emacs -Q"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#17752: 24.4.50; Scrolling other window while skeleton reads input inserts garbage

[Matthias Meulien]

Hi Lars,

Thanks for your time.
 
> Could you provide a step-by-step recipe, starting from "emacs 
> -Q"?

Steps to reproduce (I am now using GNU Emacs 28.0.50 (build 29, 
x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 
2020-11-21), commit 789ee3e1d5 from master:  1. M-x find-file 
/usr/lib/python3.7/copy.py RET 

2. C-x C-w ~/test.py RET 

3. C-v C-v C-u 15 C-n <= scroll two pages and reach an blank line 
where 
   inserting a new class definition makes sense 

4. M-x python-skeleton-class 

6. C-M-S-v

7. C-M-S-v 

8. Test <= I wrote this in the minibuffer where I was prompted 
since 
   step 4 for a class name as required by python-skeleton-class 

7. Press RET  Now the diff of the resulting file is the following. 
As you can see it's not the expected result of 
python-skeleton-class.   --- /usr/lib/python3.7/copy.py	2020-07-25 
15:03:44.000000000 +0200 +++ /home/matthias/test.py	2020-12-05 
17:53:35.503140351 +0100 @@ -46,6 +46,10 @@ 
 to control pickling: they can define methods called 
 __getinitargs__(), __getstate__() and __setstate__().  See the 
 documentation for module "pickle" for information on these 
 methods. 
+Test: +"""""" + + 
 """  import types 
@@ -105,7 +109,7 @@ 
         return x 
     return _reconstruct(x, None, *rv) 
  
- +class  
 _copy_dispatch = d = {}  def _copy_immutable(x): 
 
Diff finished.  Sat Dec  5 17:53:44 2020 

Feel free to ask if it's still unclear.

Regards,
-- 
Matthias

bug#17752: 24.4.50; Scrolling other window while skeleton reads input inserts garbage

[Lars Ingebrigtsen]

Matthias Meulien <orontee@gmail.com> writes:

>> Could you provide a step-by-step recipe, starting from "emacs -Q"?

Thanks; but it seems like something has messed up your message --
presumably Gmail, which tends to destroy mail.  Much of the mail ended
up as a single paragraph like this, which makes it hard to parse:

> python-skeleton-class.   --- /usr/lib/python3.7/copy.py	2020-07-25
> 15:03:44.000000000 +0200 +++ /home/matthias/test.py	2020-12-05
> 17:53:35.503140351 +0100 @@ -46,6 +46,10 @@  to control pickling: they
> can define methods called  __getinitargs__(), __getstate__() and
> __setstate__().  See the  documentation for module "pickle" for

Could you resend via a different method?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#17752: [Matthias Meulien] Re: bug#17752: 24.4.50; Scrolling other window while skeleton reads input inserts garbage

[Lars Ingebrigtsen]

[-- Attachment #0: Type: message/rfc822, Size: 6000 bytes --]

[-- Attachment #1.1.1: Type: text/plain, Size: 2035 bytes --]

Well, let's move to GMail web app...

> Could you provide a step-by-step recipe, starting from "emacs -Q"?

Steps to reproduce (I am now using GNU Emacs 28.0.50 (build 29,
x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of
2020-11-21), commit 789ee3e1d5 from master:

1. M-x find-file /usr/lib/python3.7/copy.py RET

2. C-x C-w ~/test.py RET

3. C-v C-v C-u 15 C-n <= scroll two pages and reach an blank line where
inserting a new class definition makes sense

4. M-x python-skeleton-class

5. C-M-S-v

6. C-M-S-v

7. Test <= I wrote this in the minibuffer where I was prompted since step 4
for a class name as required by python-skeleton-class

8. Press RET

The diff of the resulting file attached. As you can see it's not the
expected result of python-skeleton-class.

Le dim. 6 déc. 2020 à 18:14, Matthias Meulien <orontee@gmail.com> a écrit :

> Here is the recipe again. Previous mail was sent using Gnus
> through GMail. I usually have no troubles. I suppose the problem
> came from inserted diff output; Thus this time I attached the diff
> as a MIME part.
>
> > Could you provide a step-by-step recipe, starting from "emacs
> > -Q"?
>
> Steps to reproduce (I am now using GNU Emacs 28.0.50 (build 29,
> x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of
> 2020-11-21), commit 789ee3e1d5 from master:
>
> 1. M-x find-file /usr/lib/python3.7/copy.py RET  2. C-x C-w
> ~/test.py RET  3. C-v C-v C-u 15 C-n <= scroll two pages and reach
> an blank line where inserting a new class definition makes sense
> 4. M-x python-skeleton-class  6. C-M-S-v  7. C-M-S-v  8. Test <= I
> wrote this in the minibuffer where I was prompted since step 4 for
> a class name as required by python-skeleton-class  7. Press RET
>
> Now the diff of the resulting file is the following. As you can
> see it's not the expected result of python-skeleton-class.
>
>
>
> Feel free to ask if it's still unclear.   Regards,
>
> --
> Matthias
>


-- 
Matthias

[-- Attachment #1.1.2: Type: text/html, Size: 2634 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: temp.diff --]
[-- Type: text/x-patch; name=temp.diff, Size: 516 bytes --]

--- /usr/lib/python3.7/copy.py 2020-07-25
15:03:44.000000000 +0200 +++ /home/matthias/test.py     2020-12-05
17:53:35.503140351 +0100 @@ -46,6 +46,10 @@
 to control pickling: they can define methods called
 __getinitargs__(), __getstate__() and __setstate__().  See the
 documentation for module "pickle" for information on these
 methods.
+Test: +"""""" + +
 """  import types
@@ -105,5 +109,4 @@
         return x
     return _reconstruct(x, None, *rv)

- +class 
 _copy_dispatch = d = {}  def _copy_immutable(x):

bug#17752: [Matthias Meulien] Re: bug#17752: 24.4.50; Scrolling other window while skeleton reads input inserts garbage

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Well, let's move to GMail web app...

Thanks; that worked a lot better, for some reason.

>> Could you provide a step-by-step recipe, starting from "emacs -Q"?
>
> Steps to reproduce (I am now using GNU Emacs 28.0.50 (build 29,
> x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-11-21),
> commit 789ee3e1d5 from master:  
>
> 1. M-x find-file /usr/lib/python3.7/copy.py RET 

(etc)

Thanks for the clear recipe -- with that, I was able to reproduce the
bug without any problems, and I've now committed a fix for it in Emacs
28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no