From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 45688@debbugs.gnu.org
Subject: bug#45688: 28.0.50; New action for display-buffer?
Date: Tue, 19 Jan 2021 19:52:20 +0200 [thread overview]
Message-ID: <87mtx4c04z.fsf@mail.linkov.net> (raw)
In-Reply-To: <87v9c2rpfi.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 12 Jan 2021 20:36:33 +0200")
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
> One problem is that other display-buffer actions don't set
> 'display-buffer-previous-window'. It would be nice to do
> this in some low-level function in window.el.
If this is impossible to add this to window.el then a workaround is
to use such advice that helps to visit grep/xref hits in the window
where all previous hits were visited:
#+begin_src emacs-lisp
(advice-add 'window--display-buffer :around
(lambda (orig-fun &rest args)
(let ((buffer (current-buffer))
(window (apply orig-fun args)))
(with-current-buffer buffer
(setq-local display-buffer-previous-window window))
window))
'((name . window--display-buffer-set-previous-window)))
(defvar-local display-buffer-previous-window nil)
(defun display-buffer-from-grep-p (_buffer-name _action)
(with-current-buffer (window-buffer)
(derived-mode-p 'compilation-mode)))
(add-to-list 'display-buffer-alist
'(display-buffer-from-grep-p
nil (previous-window . display-buffer-previous-window)))
#+end_src
The only problem is that display-buffer-in-previous-window
doesn't support 'previous-window' as a variable, only as a value,
i.e. currently it only supports:
`(previous-window . ,display-buffer-previous-window)
maybe the following patch could be installed to support also
'(previous-window . display-buffer-previous-window)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: previous-window.patch --]
[-- Type: text/x-diff, Size: 1011 bytes --]
diff --git a/lisp/window.el b/lisp/window.el
index 0a37d16273..d6b3d69b3d 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -8239,6 +8239,7 @@ display-buffer-in-previous-window
0)
(display-buffer-reuse-frames 0)
(t (last-nonminibuffer-frame))))
+ (previous-window (cdr (assq 'previous-window alist)))
best-window second-best-window window)
;; Scan windows whether they have shown the buffer recently.
(catch 'best
@@ -8252,7 +8253,9 @@ display-buffer-in-previous-window
(throw 'best t)))))
;; When ALIST has a `previous-window' entry, that entry may override
;; anything we found so far.
- (when (and (setq window (cdr (assq 'previous-window alist)))
+ (when (and previous-window (boundp previous-window))
+ (setq previous-window (symbol-value previous-window)))
+ (when (and (setq window previous-window)
(window-live-p window)
(or (eq buffer (window-buffer window))
(not (window-dedicated-p window))))
next prev parent reply other threads:[~2021-01-19 17:52 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 12:02 bug#45688: 28.0.50; New action for display-buffer? Lars Ingebrigtsen
2021-01-06 13:36 ` martin rudalics
2021-01-06 14:09 ` Lars Ingebrigtsen
2021-01-06 15:52 ` martin rudalics
2021-01-07 11:45 ` Lars Ingebrigtsen
2021-01-07 13:18 ` martin rudalics
2021-01-07 14:47 ` Lars Ingebrigtsen
2021-01-07 15:17 ` martin rudalics
2021-01-07 15:35 ` martin rudalics
2021-01-07 15:49 ` Lars Ingebrigtsen
2021-01-07 16:54 ` martin rudalics
2021-01-06 15:45 ` Eli Zaretskii
2021-01-06 17:20 ` Lars Ingebrigtsen
2021-01-06 18:17 ` Eli Zaretskii
2021-01-07 11:40 ` Lars Ingebrigtsen
2021-01-07 13:17 ` martin rudalics
2021-01-07 15:39 ` Lars Ingebrigtsen
2021-01-07 16:54 ` martin rudalics
2021-01-10 11:24 ` Lars Ingebrigtsen
2021-01-10 16:05 ` martin rudalics
2021-01-10 16:14 ` martin rudalics
2021-01-11 14:43 ` Lars Ingebrigtsen
2021-01-11 18:23 ` martin rudalics
2021-01-11 18:55 ` martin rudalics
2021-01-19 3:20 ` Lars Ingebrigtsen
2021-01-11 19:05 ` Lars Ingebrigtsen
2021-01-12 9:06 ` martin rudalics
2021-01-19 3:26 ` Lars Ingebrigtsen
2021-01-20 8:08 ` martin rudalics
2021-01-20 16:34 ` Lars Ingebrigtsen
2021-01-20 17:11 ` martin rudalics
2021-01-19 17:50 ` Juri Linkov
2021-01-20 8:09 ` martin rudalics
2021-01-20 21:45 ` Juri Linkov
2021-01-25 19:03 ` martin rudalics
2021-01-25 20:08 ` Juri Linkov
2021-01-26 15:57 ` martin rudalics
2021-01-27 9:38 ` Juri Linkov
2021-01-28 9:40 ` martin rudalics
2021-10-03 18:12 ` Juri Linkov
2021-10-04 8:28 ` martin rudalics
2021-10-04 17:31 ` Juri Linkov
2021-10-05 6:43 ` Lars Ingebrigtsen
2021-10-05 8:10 ` martin rudalics
2021-10-05 16:49 ` Juri Linkov
2021-10-06 7:41 ` martin rudalics
2021-10-06 17:45 ` Juri Linkov
2021-10-13 8:36 ` martin rudalics
2021-01-11 14:45 ` Lars Ingebrigtsen
2021-01-07 18:43 ` Juri Linkov
2021-01-08 8:31 ` martin rudalics
2021-01-10 11:26 ` Lars Ingebrigtsen
2021-01-12 18:36 ` Juri Linkov
2021-01-19 17:52 ` Juri Linkov [this message]
2021-01-25 20:10 ` Juri Linkov
2021-01-26 15:57 ` martin rudalics
2021-01-27 9:35 ` Juri Linkov
2021-01-28 9:40 ` martin rudalics
2021-01-28 18:46 ` Juri Linkov
2021-01-29 7:51 ` martin rudalics
2021-01-06 17:41 ` Juri Linkov
2021-01-06 18:28 ` Drew Adams
2021-01-06 18:47 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtx4c04z.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=45688@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).