unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: 31749@debbugs.gnu.org
Subject: bug#31749: 26.1; Improve eldoc message commands heuristic
Date: Thu, 04 Feb 2021 10:29:15 +0100	[thread overview]
Message-ID: <87mtwktc44.fsf@gnus.org> (raw)
In-Reply-To: <87wovabbae.fsf@gmail.com> (Carlos Pita's message of "Thu, 07 Jun 2018 17:18:33 -0300")

Carlos Pita <carlosjosepita@gmail.com> writes:

> The current criterion essentially removes the echo area message after
> any command not whitelisted in eldoc-message-commands.

[...]

> Now, I might be completely wrong, but why don't you just check if
> (current-message) is nil or not? This way if any command has written to
> the echo area eldoc won't override its message. You can still keep the
> whitelist in order to force override by eldoc (although I don't see much
> value in this). You have probably thought many times about this
> alternative and rejected for reasons I'm unable to see, but it's worth
> to intent ;)

(I'm going through old bug reports that unfortunately got little response at
the time.)

The way Emacs is messaging things has been changed a bit in Emacs 28,
and fewer messages are overwritten in general, but I'm not sure whether
this also covers the eldoc messages being discussed here.

Do you have a concrete case where eldoc is overwriting a message that it
shouldn't?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2021-02-04  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 20:18 bug#31749: 26.1; Improve eldoc message commands heuristic Carlos Pita
2018-06-14  0:10 ` Noam Postavsky
2021-02-04  9:29 ` Lars Ingebrigtsen [this message]
2021-03-12  1:53   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtwktc44.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=31749@debbugs.gnu.org \
    --cc=carlosjosepita@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).