From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#31749: 26.1; Improve eldoc message commands heuristic Date: Thu, 04 Feb 2021 10:29:15 +0100 Message-ID: <87mtwktc44.fsf@gnus.org> References: <87wovabbae.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39336"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 31749@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 04 10:33:04 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7b0a-000A6g-Fc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Feb 2021 10:33:04 +0100 Original-Received: from localhost ([::1]:38668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7b0Z-00050K-Gc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Feb 2021 04:33:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7axf-0003pS-3j for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 04:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56411) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7axe-0003tM-QN for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 04:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7axe-0000Sp-Mx for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 04:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2021 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31749 X-GNU-PR-Package: emacs Original-Received: via spool by 31749-submit@debbugs.gnu.org id=B31749.16124309681664 (code B ref 31749); Thu, 04 Feb 2021 09:30:02 +0000 Original-Received: (at 31749) by debbugs.gnu.org; 4 Feb 2021 09:29:28 +0000 Original-Received: from localhost ([127.0.0.1]:39721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ax6-0000Qm-3k for submit@debbugs.gnu.org; Thu, 04 Feb 2021 04:29:28 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:55084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ax3-0000QU-Rt for 31749@debbugs.gnu.org; Thu, 04 Feb 2021 04:29:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GAIt8zgRVivortUsiaSTPc6/tOMlT8H4NqvlF8XQcXY=; b=EQBqVJ6gNLOEO9mHVh8nW+RBsT RUNlB4Wzna1Vy2sxQ11VQifa1Eh12jECXSgoS/Xa63jMB3ILtjyECSjrbhO+TWxxsEBCx6dga0fkS pTaWIGgJk6tozK/IEjFfUMySMP/hGwrg/3D9GgDddM3Hwras7uEeK8+5CKIV8jzHuOJ4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7awv-0005EG-4l; Thu, 04 Feb 2021 10:29:19 +0100 X-Now-Playing: Mac T Dog's _Rogue Pulse: Gravity Collapse (9)_: "Talk Money" In-Reply-To: <87wovabbae.fsf@gmail.com> (Carlos Pita's message of "Thu, 07 Jun 2018 17:18:33 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199281 Archived-At: Carlos Pita writes: > The current criterion essentially removes the echo area message after > any command not whitelisted in eldoc-message-commands. [...] > Now, I might be completely wrong, but why don't you just check if > (current-message) is nil or not? This way if any command has written to > the echo area eldoc won't override its message. You can still keep the > whitelist in order to force override by eldoc (although I don't see much > value in this). You have probably thought many times about this > alternative and rejected for reasons I'm unable to see, but it's worth > to intent ;) (I'm going through old bug reports that unfortunately got little response at the time.) The way Emacs is messaging things has been changed a bit in Emacs 28, and fewer messages are overwritten in general, but I'm not sure whether this also covers the eldoc messages being discussed here. Do you have a concrete case where eldoc is overwriting a message that it shouldn't? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no