From: Lars Ingebrigtsen <larsi@gnus.org>
To: Hugh Daschbach <hugh@ccss.com>
Cc: 50051@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#50051: 28.0.50; easymenu defined popup menus broken since 27.1
Date: Sat, 14 Aug 2021 14:39:09 +0200 [thread overview]
Message-ID: <87mtpktd3m.fsf@gnus.org> (raw)
In-Reply-To: <871r6x6lqg.fsf@ccss.com> (Hugh Daschbach's message of "Fri, 13 Aug 2021 15:08:55 -0700")
Hugh Daschbach <hugh@ccss.com> writes:
> This opens a window with *popup-tests* buffer. Right click on the text
> "Right click here." to generate the wrong-type-argument error.
>
> This test works with 26.3. Bisecting the Emacs source tree reveals this
> regression was introduced by the first hunk in
> a070bd1c8b5213ad469d41dd80d392f924644aed.
Stefan, this was the patch that replaced some lambdas with closures in
easymenu. I see that parts of that patch was reverted(ish), but not the
bit that's triggering this problem.
Here's the reverted thing:
diff --git a/lisp/emacs-lisp/easymenu.el b/lisp/emacs-lisp/easymenu.el
index 292d50b91a..15b8bef428 100644
--- a/lisp/emacs-lisp/easymenu.el
+++ b/lisp/emacs-lisp/easymenu.el
@@ -475,7 +475,7 @@ easy-menu-make-symbol
;; `functionp' is probably not needed.
(functionp callback) noexp)
callback
- (lambda () (interactive) callback)))
+ (eval `(lambda () (interactive) ,callback) t)))
command))
I briefly tried to debug the current problem, but it wasn't immediately
clear what the correct fix here would be...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-08-14 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 22:08 bug#50051: 28.0.50; easymenu defined popup menus broken since 27.1 Hugh Daschbach
2021-08-14 12:39 ` Lars Ingebrigtsen [this message]
2021-08-14 16:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-14 16:29 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtpktd3m.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=50051@debbugs.gnu.org \
--cc=hugh@ccss.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).