From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50051: 28.0.50; easymenu defined popup menus broken since 27.1 Date: Sat, 14 Aug 2021 14:39:09 +0200 Message-ID: <87mtpktd3m.fsf@gnus.org> References: <871r6x6lqg.fsf@ccss.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23399"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50051@debbugs.gnu.org, monnier@iro.umontreal.ca To: Hugh Daschbach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 14 14:40:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEsxN-0005u3-Vr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Aug 2021 14:40:10 +0200 Original-Received: from localhost ([::1]:57126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEsxM-0006nd-E1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Aug 2021 08:40:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEsxG-0006nH-Jt for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 08:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEsxG-00057J-Af for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 08:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mEsxG-00068y-7h for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 08:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Aug 2021 12:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50051 X-GNU-PR-Package: emacs Original-Received: via spool by 50051-submit@debbugs.gnu.org id=B50051.162894477223578 (code B ref 50051); Sat, 14 Aug 2021 12:40:02 +0000 Original-Received: (at 50051) by debbugs.gnu.org; 14 Aug 2021 12:39:32 +0000 Original-Received: from localhost ([127.0.0.1]:43794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEswi-00068A-0P for submit@debbugs.gnu.org; Sat, 14 Aug 2021 08:39:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:32908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEswc-00067o-6k for 50051@debbugs.gnu.org; Sat, 14 Aug 2021 08:39:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d1rluu8PT0po4kLMXwG+UnuaBWF26hV4mmkqPn4KqlE=; b=ITkez1OPpww+fMX6H/RWKH1KKf j43PJwQ3p31qVSDX5U5ibHXEoHUsbkO5gO2tcu6zn/cgtM40ymuLFtQdUBSYOnPif4gzSJlqS1Cb4 cRwlyrEdZsFA2viGH3MWaLnpQc0f0DGZofwJFL/LOO1pGbwDJmKYLcN4j2KHl2EoPOzU=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEswP-0000rK-Sl; Sat, 14 Aug 2021 14:39:14 +0200 In-Reply-To: <871r6x6lqg.fsf@ccss.com> (Hugh Daschbach's message of "Fri, 13 Aug 2021 15:08:55 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211831 Archived-At: Hugh Daschbach writes: > This opens a window with *popup-tests* buffer. Right click on the text > "Right click here." to generate the wrong-type-argument error. > > This test works with 26.3. Bisecting the Emacs source tree reveals this > regression was introduced by the first hunk in > a070bd1c8b5213ad469d41dd80d392f924644aed. Stefan, this was the patch that replaced some lambdas with closures in easymenu. I see that parts of that patch was reverted(ish), but not the bit that's triggering this problem. Here's the reverted thing: diff --git a/lisp/emacs-lisp/easymenu.el b/lisp/emacs-lisp/easymenu.el index 292d50b91a..15b8bef428 100644 --- a/lisp/emacs-lisp/easymenu.el +++ b/lisp/emacs-lisp/easymenu.el @@ -475,7 +475,7 @@ easy-menu-make-symbol ;; `functionp' is probably not needed. (functionp callback) noexp) callback - (lambda () (interactive) callback))) + (eval `(lambda () (interactive) ,callback) t))) command)) I briefly tried to debug the current problem, but it wasn't immediately clear what the correct fix here would be... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no