unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Matthias Meulien <orontee@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 54030@debbugs.gnu.org
Subject: bug#54030: 29.0.50; [PATCH] Extend bookmark menu with column displaying handler type
Date: Sun, 20 Feb 2022 11:01:31 +0100	[thread overview]
Message-ID: <87mtilluv8.fsf@gmail.com> (raw)
In-Reply-To: <87wnhtln7i.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 17 Feb 2022 12:57:53 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Looks good to me, so I've pushed it to Emacs 29.  (But I made the type
> column shorter since the types probably won't be very long.)

Thank you, Lars.

Unfortunately, I've forgotten two bookmark handlers:
One for Gnus summary buffers and one for man pages. Could you add the
missing two lines?

(I didn't try to support xwidgets bookmarks since I never compiled with
this option and I've no knowledge of how to test that feature.)

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 8fb07d5905..1be5a48068 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -13278,6 +13278,8 @@ gnus-summary-bookmark-jump
        (buffer . ,(current-buffer))
        . ,(bookmark-get-bookmark-record bookmark)))))
 
+(put 'gnus-summary-bookmark-jump 'bookmark-handler-type "Gnus")
+
 (gnus-summary-make-all-marking-commands)
 
 (provide 'gnus-sum)
diff --git a/lisp/man.el b/lisp/man.el
index a53a696c31..951e0ef9ad 100644
--- a/lisp/man.el
+++ b/lisp/man.el
@@ -1976,6 +1976,8 @@ Man-bookmark-jump
     (bookmark-default-handler
      `("" (buffer . ,buf) . ,(bookmark-get-bookmark-record bookmark)))))
 
+(put 'Man-bookmark-jump 'bookmark-handler-type "Man")
+
 ;;; Mouse support
 (defun Man-at-mouse (e)
   "Open man manual at point."
-- 
Matthias





  parent reply	other threads:[~2022-02-20 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 19:55 bug#54030: 29.0.50; [PATCH] Extend bookmark menu with column displaying handler type Matthias Meulien
2022-02-17 11:57 ` Lars Ingebrigtsen
2022-02-17 12:50   ` Matthias Meulien
2022-02-20 10:01   ` Matthias Meulien [this message]
2022-02-20 12:23     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtilluv8.fsf@gmail.com \
    --to=orontee@gmail.com \
    --cc=54030@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).