From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#54030: 29.0.50; [PATCH] Extend bookmark menu with column displaying handler type Date: Sun, 20 Feb 2022 11:01:31 +0100 Message-ID: <87mtilluv8.fsf@gmail.com> References: <877d9umvrc.fsf@gmail.com> <87wnhtln7i.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33173"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54030@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 20 11:02:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLj2i-0008L6-FK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 11:02:12 +0100 Original-Received: from localhost ([::1]:39330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLj2h-0002mo-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 05:02:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLj2Y-0002kv-PR for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 05:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLj2Y-0003wO-FT for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 05:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLj2Y-0007ns-99 for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 05:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Feb 2022 10:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54030 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54030-submit@debbugs.gnu.org id=B54030.164535130129966 (code B ref 54030); Sun, 20 Feb 2022 10:02:02 +0000 Original-Received: (at 54030) by debbugs.gnu.org; 20 Feb 2022 10:01:41 +0000 Original-Received: from localhost ([127.0.0.1]:59392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLj2D-0007nG-3J for submit@debbugs.gnu.org; Sun, 20 Feb 2022 05:01:41 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:39899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLj2A-0007n2-UV for 54030@debbugs.gnu.org; Sun, 20 Feb 2022 05:01:39 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id d27so21963596wrc.6 for <54030@debbugs.gnu.org>; Sun, 20 Feb 2022 02:01:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=m0j9uLw7O4grlmbnYZiwdy8yCVCHxnWkdS2MExzrYSc=; b=VIs/2Sa3UUCiIeHnkagUIgr7UD6CJtXLerMrMWCLTUIiToGRNP+RjNN1RNrVyWrC2p Uh4wJt2D+MVttFD3RXlsE+wQryHE8RDu/twxIx+lNeQetqsLYomn/BhuqIHCnzwmVcEC C/A9nawOcfSVfUzWeC76+NARoOpbC79lepTNWWNty5u+LhMIEuEmHwMj9cq+toL4lrTA T1iKPIjnqO3bRkSSLDBRmLdYSE2o7XVzHGjlsjPxA0hiPIAUmOD4B4RQJ6k21RAaLOvq I+2Fzqd5IjFvVVQ4N3qFIvZaXlbb/xHwY9QAZNwwwnziRoOHytP+jvu6hxg09cuapFNz REHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=m0j9uLw7O4grlmbnYZiwdy8yCVCHxnWkdS2MExzrYSc=; b=6drZWSnKcf/ZiO0QKgnO22Vj/92xEpYlo/HlkoFx5Z9F/yxTNd8UAv/HZZDE2ByPbh FTmh54vsHkMfc7+E8jc2WHZAIMgTaET1U6TqMLUUA2xBn4KL/0Vp8kOIILjJPB8WyS84 bbdaJBpqI6AGsaml+Z73Jk86F/dtLCA+1zNwedaHVaOH2TtnuMAodKSICL4pgUWNNAJj yePsaGjZxoOJl97bpb1rBszU+USTLUFAOCxkPDUkX1TaZDboyq+1DiBuav80MBICLv5/ J3HogIUH4vPUh6teV9X0qsSl4X0tuY0Y6ktuHda1f4SqLRBFMJEg68PqJoZCbR8vDWt1 fhgg== X-Gm-Message-State: AOAM530gy+gH/NPMx/MJ57QGpbL2FiUuQUtbgRHXgySvRa9e5U0DFRrY ZQz/pin4wQTHgGcKSXUHTNNmlnDzTCFI5A== X-Google-Smtp-Source: ABdhPJwbqiJ9vP3r09WkJampsofmbUTueoZiC3B2FZTfnep+CQ+U9g5DRH3A6y2Fh4fI7OizLdLBCA== X-Received: by 2002:adf:e18f:0:b0:1e8:7b4e:7a1e with SMTP id az15-20020adfe18f000000b001e87b4e7a1emr12022945wrb.680.1645351292813; Sun, 20 Feb 2022 02:01:32 -0800 (PST) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id c17sm4325581wmh.31.2022.02.20.02.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 02:01:32 -0800 (PST) In-Reply-To: <87wnhtln7i.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 17 Feb 2022 12:57:53 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227220 Archived-At: Lars Ingebrigtsen writes: > Looks good to me, so I've pushed it to Emacs 29. (But I made the type > column shorter since the types probably won't be very long.) Thank you, Lars. Unfortunately, I've forgotten two bookmark handlers: One for Gnus summary buffers and one for man pages. Could you add the missing two lines? (I didn't try to support xwidgets bookmarks since I never compiled with this option and I've no knowledge of how to test that feature.) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index 8fb07d5905..1be5a48068 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -13278,6 +13278,8 @@ gnus-summary-bookmark-jump (buffer . ,(current-buffer)) . ,(bookmark-get-bookmark-record bookmark))))) +(put 'gnus-summary-bookmark-jump 'bookmark-handler-type "Gnus") + (gnus-summary-make-all-marking-commands) (provide 'gnus-sum) diff --git a/lisp/man.el b/lisp/man.el index a53a696c31..951e0ef9ad 100644 --- a/lisp/man.el +++ b/lisp/man.el @@ -1976,6 +1976,8 @@ Man-bookmark-jump (bookmark-default-handler `("" (buffer . ,buf) . ,(bookmark-get-bookmark-record bookmark))))) +(put 'Man-bookmark-jump 'bookmark-handler-type "Man") + ;;; Mouse support (defun Man-at-mouse (e) "Open man manual at point." -- Matthias