unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#54324: 29.0.50; Don't error during debbugs-gnu-rescan
@ 2022-03-10  0:19 Eric Abrahamsen
  2022-03-10  8:02 ` Michael Albinus
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Abrahamsen @ 2022-03-10  0:19 UTC (permalink / raw)
  To: 54324; +Cc: michael.albinus

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]


`debbugs-gnu-rescan' will error if point isn't on a current bug id,
which isn't necessary. This patch avoids that by passing the NOERROR arg
to `debbugs-gnu-current-id'.

Eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Pass-NOERROR-arg-to-debbugs-gnu-current-id-when-resc.patch --]
[-- Type: text/x-patch, Size: 1010 bytes --]

From 81ba1905bcb6c8a8fc927df92e9fc525ab71ce74 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Wed, 9 Mar 2022 16:14:59 -0800
Subject: [PATCH] Pass NOERROR arg to debbugs-gnu-current-id when rescanning

* debbugs-gnu.el (debbugs-gnu-rescan): There's no need for the rescan
process to require point to be on a bug id.
---
 debbugs-gnu.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debbugs-gnu.el b/debbugs-gnu.el
index 770a832cb3..ef946fc90f 100644
--- a/debbugs-gnu.el
+++ b/debbugs-gnu.el
@@ -1201,7 +1201,7 @@ If NOCACHE is non-nil, bug information is retrieved from the debbugs server.
 Interactively, it is non-nil with the prefix argument."
   (interactive
    (list current-prefix-arg))
-  (let ((id (debbugs-gnu-current-id))
+  (let ((id (debbugs-gnu-current-id t))
 	(debbugs-gnu-current-query debbugs-gnu-local-query)
 	(debbugs-gnu-current-filter debbugs-gnu-local-filter)
 	(debbugs-gnu-current-suppress debbugs-gnu-local-suppress)
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#54324: 29.0.50; Don't error during debbugs-gnu-rescan
  2022-03-10  0:19 bug#54324: 29.0.50; Don't error during debbugs-gnu-rescan Eric Abrahamsen
@ 2022-03-10  8:02 ` Michael Albinus
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Albinus @ 2022-03-10  8:02 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: 54324-done

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

Hi Eric,

> `debbugs-gnu-rescan' will error if point isn't on a current bug id,
> which isn't necessary. This patch avoids that by passing the NOERROR arg
> to `debbugs-gnu-current-id'.

Thanks for the patch, I've applied it to the git repo. There will be a
new debbugs 0.31. Closing the bug.

> Eric

Best regards, Michael.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-10  8:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10  0:19 bug#54324: 29.0.50; Don't error during debbugs-gnu-rescan Eric Abrahamsen
2022-03-10  8:02 ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).