* bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro
@ 2023-08-09 10:49 Richard Copley
2023-08-09 12:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 4+ messages in thread
From: Richard Copley @ 2023-08-09 10:49 UTC (permalink / raw)
To: 65175, luangruo
When isearch is invoked from a keyboard macro, an error is signalled.
Recipe:
C-x ( ;; kmacro-start-macro
C-s ;; isearch-forward
e ;; isearch-printing-char
<return> ;; isearch-exit
C-x ) ;; kmacro-end-macro
C-x e ;; kmacro-end-and-call-macro
Backtrace:
Lisp error: (error "Invalid argument macro in ‘get-device-terminal’")
error("Invalid argument %s in `get-device-terminal'" macro)
get-device-terminal(macro)
frames-on-display-list(macro)
framep-on-display(macro)
device-class(macro nil)
isearch-mode(t t nil nil)
isearch-forward-regexp(nil 1)
funcall-interactively(isearch-forward-regexp nil 1)
command-execute(isearch-forward-regexp)
kmacro-call-macro(1 nil)
kmacro-end-and-call-macro(1)
funcall-interactively(kmacro-end-and-call-macro 1)
command-execute(kmacro-end-and-call-macro)
From the docstring for ‘last-event-frame’: "If the last event came
from a keyboard macro, this is set to ‘macro’." When the value is
‘macro’, it should not be passed to ‘device-class’.
Introduced in commit:
e3b50ec8ec1b8d1246aa2496f3fe8bf98d354545
Author: Po Lu <luangruo@yahoo.com>
AuthorDate: Sat Jan 28 14:29:51 2023 +0800
Update Android port
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro
2023-08-09 10:49 bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro Richard Copley
@ 2023-08-09 12:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 16:22 ` Richard Copley
0 siblings, 1 reply; 4+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-08-09 12:44 UTC (permalink / raw)
To: Richard Copley; +Cc: 65175
Richard Copley <rcopley@gmail.com> writes:
> When isearch is invoked from a keyboard macro, an error is signalled.
>
> Recipe:
> C-x ( ;; kmacro-start-macro
> C-s ;; isearch-forward
> e ;; isearch-printing-char
> <return> ;; isearch-exit
> C-x ) ;; kmacro-end-macro
> C-x e ;; kmacro-end-and-call-macro
>
> Backtrace:
> Lisp error: (error "Invalid argument macro in ‘get-device-terminal’")
> error("Invalid argument %s in `get-device-terminal'" macro)
> get-device-terminal(macro)
> frames-on-display-list(macro)
> framep-on-display(macro)
> device-class(macro nil)
> isearch-mode(t t nil nil)
> isearch-forward-regexp(nil 1)
> funcall-interactively(isearch-forward-regexp nil 1)
> command-execute(isearch-forward-regexp)
> kmacro-call-macro(1 nil)
> kmacro-end-and-call-macro(1)
> funcall-interactively(kmacro-end-and-call-macro 1)
> command-execute(kmacro-end-and-call-macro)
>
>>From the docstring for ‘last-event-frame’: "If the last event came
> from a keyboard macro, this is set to ‘macro’." When the value is
> ‘macro’, it should not be passed to ‘device-class’.
>
> Introduced in commit:
> e3b50ec8ec1b8d1246aa2496f3fe8bf98d354545
> Author: Po Lu <luangruo@yahoo.com>
> AuthorDate: Sat Jan 28 14:29:51 2023 +0800
>
> Update Android port
I think this should be fixed now. Please test and ack, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro
2023-08-09 12:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-08-09 16:22 ` Richard Copley
2023-08-10 0:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 4+ messages in thread
From: Richard Copley @ 2023-08-09 16:22 UTC (permalink / raw)
To: Po Lu; +Cc: 65175
On Wed, 9 Aug 2023 at 13:44, Po Lu <luangruo@yahoo.com> wrote:
> I think this should be fixed now. Please test and ack, thanks.
Yes, that works. Thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro
2023-08-09 16:22 ` Richard Copley
@ 2023-08-10 0:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 4+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-08-10 0:02 UTC (permalink / raw)
To: Richard Copley; +Cc: 65175-done
Richard Copley <rcopley@gmail.com> writes:
> On Wed, 9 Aug 2023 at 13:44, Po Lu <luangruo@yahoo.com> wrote:
>> I think this should be fixed now. Please test and ack, thanks.
>
> Yes, that works. Thank you.
Closing, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-10 0:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-09 10:49 bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro Richard Copley
2023-08-09 12:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 16:22 ` Richard Copley
2023-08-10 0:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).