unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#5545: iswitchb assumes bookmark-alist is bound
@ 2010-02-08 21:24 Glenn Morris
  2010-02-10  9:28 ` Chong Yidong
  0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2010-02-08 21:24 UTC (permalink / raw)
  To: 5545; +Cc: jwiegley


In the current trunk, since 2010-02-03:

Compiler warning:

iswitchb.el:1293:19:Warning: reference to free variable `bookmark-alist'

Example:

emacs -Q \
   --eval '(progn (setq iswitchb-use-virtual-buffers t) (iswitchb-mode))'

C-x b 1

-> Error in post-command-hook: (void-variable bookmark-alist)


The documentation of iswitchb-use-virtual-buffers does not mention
searching bookmarks, it only mentions recentf. If it is non-nil, it
activates recentf-mode, but there is no such feature for bookmarks.

Also there is no NEWS entry for this change.






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#5545: iswitchb assumes bookmark-alist is bound
  2010-02-08 21:24 bug#5545: iswitchb assumes bookmark-alist is bound Glenn Morris
@ 2010-02-10  9:28 ` Chong Yidong
  0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2010-02-10  9:28 UTC (permalink / raw)
  To: Glenn Morris; +Cc: John Wiegley, 5545

> In the current trunk, since 2010-02-03:
>
> Compiler warning:
>
> iswitchb.el:1293:19:Warning: reference to free variable `bookmark-alist'
>
> Example:
>
> emacs -Q \
>    --eval '(progn (setq iswitchb-use-virtual-buffers t) (iswitchb-mode))'
>
> C-x b 1
>
> -> Error in post-command-hook: (void-variable bookmark-alist)
>
> The documentation of iswitchb-use-virtual-buffers does not mention
> searching bookmarks, it only mentions recentf. If it is non-nil, it
> activates recentf-mode, but there is no such feature for bookmarks.
>
> Also there is no NEWS entry for this change.

I don't think this change is consistent with the feature freeze, so I
have reverted it for now.  We can revisit this after the release.






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-10  9:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-08 21:24 bug#5545: iswitchb assumes bookmark-alist is bound Glenn Morris
2010-02-10  9:28 ` Chong Yidong

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).