From: npostavs@users.sourceforge.net
To: Gemini Lasswell <gazally@runbox.com>
Cc: Michael Albinus <michael.albinus@gmx.de>, 28227@debbugs.gnu.org
Subject: bug#28227: 26.0.50; Tramp tests are slow
Date: Wed, 30 Aug 2017 22:26:33 -0400 [thread overview]
Message-ID: <87lgm079ra.fsf@users.sourceforge.net> (raw)
In-Reply-To: <874lsok15a.fsf@runbox.com> (Gemini Lasswell's message of "Wed, 30 Aug 2017 18:20:08 -0700")
Gemini Lasswell <gazally@runbox.com> writes:
> +(defmacro tramp-lookup-syntax (alist)
> + "Look up a syntax string in ALIST according to `tramp-compat-tramp-syntax.'
> +Raise an error if `tramp-syntax' is invalid."
> + `(let ((result (cdr (assq (tramp-compat-tramp-syntax) ,alist))))
> + (or result
> + (error "Wrong `tramp-syntax' %s" tramp-syntax))))
Was there a reason to defmacro instead of defun here? If it's
performance, perhaps defsubst could work instead?
(also, the let-binding seems redundant)
next prev parent reply other threads:[~2017-08-31 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 21:03 bug#28227: 26.0.50; Tramp tests are slow Gemini Lasswell
2017-08-25 8:04 ` Michael Albinus
[not found] ` <874lsok15a.fsf@runbox.com>
2017-08-31 2:26 ` npostavs [this message]
2017-08-31 14:46 ` Gemini Lasswell
2017-09-01 12:28 ` Michael Albinus
2017-09-04 22:43 ` Gemini Lasswell
2017-09-05 7:45 ` Michael Albinus
2017-09-09 16:27 ` Gemini Lasswell
2017-09-09 17:47 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgm079ra.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=28227@debbugs.gnu.org \
--cc=gazally@runbox.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).