unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Gemini Lasswell <gazally@runbox.com>
Cc: 28227@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#28227: 26.0.50; Tramp tests are slow
Date: Fri, 01 Sep 2017 14:28:33 +0200	[thread overview]
Message-ID: <877exili1a.fsf@detlef> (raw)
In-Reply-To: <87inh3iym8.fsf@runbox.com> (Gemini Lasswell's message of "Thu, 31 Aug 2017 07:46:33 -0700")

Gemini Lasswell <gazally@runbox.com> writes:

Hi Gemini,

> Here's a new patch which uses defun and doesn't have the let binding.
> Performance is not noticably different.

Looks good to me, thanks a lot! You could apply this to master.

`tramp-prefix-method-regexp-alist' might be renamed to
`tramp-method-regexp-alist'.

And `tramp-*-regexp-alist' might be derived from `tramp-*-format-alist',
as the docstring says. Otherwise, you would use the same string literals
twice, which is always good for errors during maintenance. Something like

(defconst tramp-prefix-regexp-alist
  (mapcar (lambda (x) (cons (car x) (concat "^" (regexp-quote (cdr x)))))
          tramp-prefix-format-alist)
  "Alist of regexps matching the beginnings of Tramp file names.
Keyed by Tramp syntax. Derived from `tramp-prefix-format-alist'.")

Best regards, Michael.





  reply	other threads:[~2017-09-01 12:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 21:03 bug#28227: 26.0.50; Tramp tests are slow Gemini Lasswell
2017-08-25  8:04 ` Michael Albinus
     [not found]   ` <874lsok15a.fsf@runbox.com>
2017-08-31  2:26     ` npostavs
2017-08-31 14:46       ` Gemini Lasswell
2017-09-01 12:28         ` Michael Albinus [this message]
2017-09-04 22:43           ` Gemini Lasswell
2017-09-05  7:45             ` Michael Albinus
2017-09-09 16:27               ` Gemini Lasswell
2017-09-09 17:47                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877exili1a.fsf@detlef \
    --to=michael.albinus@gmx.de \
    --cc=28227@debbugs.gnu.org \
    --cc=gazally@runbox.com \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).