bug#56704: 28.1.90; shr: The DOM is lost in the rendered result

bug#56704: 28.1.90; shr: The DOM is lost in the rendered result

[Damien Cassou]

Hi,

SHR doesn't link the text being inserted in the buffer and DOM node
being rendered. This means it is not possible to implement some use
cases, e.g.,

- inspect/copy the DOM node rendered at point;

- share/bookmark a link to a particular section of a page (which
  requires knowing the id attribute of the enclosing DOM node).

I fixed this by changing shr-generic from:

(defsubst shr-generic (dom)
  (dolist (sub (dom-children dom))
    (if (stringp sub)
	(shr-insert sub)
      (shr-descend sub))))

to

(defsubst shr-generic (dom)
  (let ((start (point)))
    (dolist (sub (dom-children dom))
      (if (stringp sub)
	  (shr-insert sub)
        (shr-descend sub)))
    (unless (eq start (point-max))
      (put-text-property start (1+ start) 'shr-dom dom))))


This seems to work great.

Is this change desirable? Do you want a patch?

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

bug#56704: 28.1.90; shr: The DOM is lost in the rendered result

[Lars Ingebrigtsen]

Damien Cassou <damien@cassou.me> writes:

> SHR doesn't link the text being inserted in the buffer and DOM node
> being rendered.

Yes, shr is already slow enough, so basically all "debugging"-like
things were eschewed.  It'd be nice to have, but if shr is unusably
slow, that's not nice, either.

So we won't be adding something like this, and I'm therefore closing
this bug report.