From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Danny Freeman <danny@dfreeman.email>
Cc: 61371@debbugs.gnu.org, michael.albinus@gmx.de, joaotavora@gmail.com
Subject: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot
Date: Wed, 15 Feb 2023 19:09:56 +0100 [thread overview]
Message-ID: <87leky7qbv.fsf@thornhill.no> (raw)
In-Reply-To: <875yc2by79.fsf@dfreeman.email>
Danny Freeman <danny@dfreeman.email> writes:
> Danny Freeman <danny@dfreeman.email> writes:
>
>> Theodor Thornhill <theo@thornhill.no> writes:
>>
>>> Michael Albinus <michael.albinus@gmx.de> writes:
>>>
>>>> Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
>>>> of text editors" <bug-gnu-emacs@gnu.org> writes:
>>>>
>>>>> Hi!
>>>>
>>>> Hi Theo,
>>>>
>>>>> When using Eglot along with Java there are some hacks that needs to be
>>>>> made to make things functional. One of the more important things is to
>>>>> add support for the jdt:// file scheme that is sent when you try to
>>>>> go-to-definition on a system or third party lib.
>>>>>
>>>>> As you can see, we need to query the server with
>>>>> :java/classFileContents, and also register with the server to send it
>>>>> with the :extendedClientCapabilities on initialization.
>>>>>
>>>>> Is there a place this code could live? Maybe in the new java-ts-mode?
>>>>
>>>> There is the jarchive package on GNU ELPA. Could this be used, perhaps extended?
>>>>
>>>>> Theo
>>>>
>>>> Best regards, Michael.
>>>
>>> Maybe! Don't know what it does, but I'll check it out - thanks!
>>>
>>> Theo
>>
>> JDT urls are outside the scope of jarchive. I would think of them less
>> as URLs and more as tokens to be decoded by the LSP server that provides
>> them. JDT urls are intended to be sent back to the LSP server using a
>> special extension method.
>>
>> There is an issue open in the eglot-java repo to implement this but I
>> have been too busy to get around to it
>> https://github.com/yveszoundi/eglot-java/issues/6
>>
>> Someone has responded there with some code similar to jarchive that will
>> parse the JDT urls and try to open them, but I wouldn't consider that a
>> permanent solution. JDT urls are not standardized and subject to change
>> by the JDT LSP maintainers.
>
> I think this bug can be closed now, it was fixed in the eglot-java
> package. See: https://github.com/yveszoundi/eglot-java/issues/6
>
> Thank you,
> --
> Danny Freeman
I agree :-)
next prev parent reply other threads:[~2023-02-15 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 19:09 bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-09 9:47 ` Michael Albinus
2023-02-09 10:42 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-10 20:32 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 18:05 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 18:09 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-06 0:05 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leky7qbv.fsf@thornhill.no \
--to=bug-gnu-emacs@gnu.org \
--cc=61371@debbugs.gnu.org \
--cc=danny@dfreeman.email \
--cc=joaotavora@gmail.com \
--cc=michael.albinus@gmx.de \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).