From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot Date: Wed, 15 Feb 2023 19:09:56 +0100 Message-ID: <87leky7qbv.fsf@thornhill.no> References: <87r0v06kjv.fsf@thornhill.no> <875ycbkw62.fsf@gmx.de> <87v8kb9l2a.fsf@thornhill.no> <87h6vt8dfb.fsf@dfreeman.email> <875yc2by79.fsf@dfreeman.email> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25550"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61371@debbugs.gnu.org, michael.albinus@gmx.de, joaotavora@gmail.com To: Danny Freeman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 15 19:11:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSMFM-0006TF-Qh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Feb 2023 19:11:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSMFD-0006Mf-OM; Wed, 15 Feb 2023 13:11:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSMFC-0006MW-Hz for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 13:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSMFC-0002Sw-9I for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 13:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSMFC-0003ts-5n for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 13:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2023 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61371 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Michael Albinus , 61371@debbugs.gnu.org, joaotavora@gmail.com Original-Received: via spool by 61371-submit@debbugs.gnu.org id=B61371.167648460214887 (code B ref 61371); Wed, 15 Feb 2023 18:11:02 +0000 Original-Received: (at 61371) by debbugs.gnu.org; 15 Feb 2023 18:10:02 +0000 Original-Received: from localhost ([127.0.0.1]:33914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSMED-0003rq-TV for submit@debbugs.gnu.org; Wed, 15 Feb 2023 13:10:02 -0500 Original-Received: from out-242.mta0.migadu.com ([91.218.175.242]:24610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSMEA-0003rP-KQ for 61371@debbugs.gnu.org; Wed, 15 Feb 2023 13:10:00 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1676484597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zucvu2lpj+DU2iw5QAcE/AdH47Y20EG5SezCpzM0REU=; b=BlGKvDznB3T47F1mmEqaZWdnB2ZIiFkynoyFO9HysMhXeypGoPhjHkcPHYEsI1wmj0CNgx Zyz1RTfRr7xVQmUWqYUN12wlB4vo9V9DvW/+mqSfAfTFQT09tXlU0c8q7FB2WPu27c3oJn EyH6Abv8L7LDJufBvNJ3Wbl45AqaRN8LK7Vm+YEuIRJGirP5jl+8qiBIRGRZleB6apjVe2 YUfKK7SdPX/EY9/NUTi68EFCUDLdMZ0L5lzg4K5wX6ozllTqXPHKScLp3JihVFKoV/bKOa CB5o4eGtV/pqcmwXIiv/JlH3Qmgg3BChZ5LjtgsYshAdGGCWywSPaenQVOxqhw== In-Reply-To: <875yc2by79.fsf@dfreeman.email> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255756 Archived-At: Danny Freeman writes: > Danny Freeman writes: > >> Theodor Thornhill writes: >> >>> Michael Albinus writes: >>> >>>> Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife >>>> of text editors" writes: >>>> >>>>> Hi! >>>> >>>> Hi Theo, >>>> >>>>> When using Eglot along with Java there are some hacks that needs to be >>>>> made to make things functional. One of the more important things is to >>>>> add support for the jdt:// file scheme that is sent when you try to >>>>> go-to-definition on a system or third party lib. >>>>> >>>>> As you can see, we need to query the server with >>>>> :java/classFileContents, and also register with the server to send it >>>>> with the :extendedClientCapabilities on initialization. >>>>> >>>>> Is there a place this code could live? Maybe in the new java-ts-mode? >>>> >>>> There is the jarchive package on GNU ELPA. Could this be used, perhaps extended? >>>> >>>>> Theo >>>> >>>> Best regards, Michael. >>> >>> Maybe! Don't know what it does, but I'll check it out - thanks! >>> >>> Theo >> >> JDT urls are outside the scope of jarchive. I would think of them less >> as URLs and more as tokens to be decoded by the LSP server that provides >> them. JDT urls are intended to be sent back to the LSP server using a >> special extension method. >> >> There is an issue open in the eglot-java repo to implement this but I >> have been too busy to get around to it >> https://github.com/yveszoundi/eglot-java/issues/6 >> >> Someone has responded there with some code similar to jarchive that will >> parse the JDT urls and try to open them, but I wouldn't consider that a >> permanent solution. JDT urls are not standardized and subject to change >> by the JDT LSP maintainers. > > I think this bug can be closed now, it was fixed in the eglot-java > package. See: https://github.com/yveszoundi/eglot-java/issues/6 > > Thank you, > -- > Danny Freeman I agree :-)