unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Basil Contovounesios <contovob@tcd.ie>, 64275@debbugs.gnu.org
Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode
Date: Mon, 31 Jul 2023 09:22:40 +0200	[thread overview]
Message-ID: <87leew7d7u.fsf@gmail.com> (raw)
In-Reply-To: <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev>


Dmitry Gutov <dmitry@gutov.dev> writes:

> On 30/07/2023 10:53, Wilhelm Kirschbaum wrote:
>>> With the new patch, it will continue highlight the sigil name 
>>> ("r") in
>>> regexps, but no in other sigil types (s/c/w).
>>>
>> Incorrect, just below there is a:
>>            (sigil) @font-lock-string-face)
>> without a match, so they will be highlighted, but just more
>> generically
>> as we don't know which sigils the user might have assigned.
>
> Why not add elixir-ts-font-sigil-name-face in that matcher as 
> well?

I think it is worth keeping the default/fallback case as simple as
possible and if there is a need to add special font to more 
specific
cases.  In this case it would have no impact if the font is not
customized.  Is there a reason you believe it would be better?





  reply	other threads:[~2023-07-31  7:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-24 20:14 bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Wilhelm Kirschbaum
2023-06-25  8:53 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25  9:00   ` Wilhelm Kirschbaum
2023-07-29 18:31     ` Wilhelm Kirschbaum
2023-07-30  2:06     ` Dmitry Gutov
2023-07-30  7:53       ` Wilhelm Kirschbaum
2023-07-30 12:09         ` Dmitry Gutov
2023-07-31  7:22           ` Wilhelm Kirschbaum [this message]
2023-08-01 11:59             ` Dmitry Gutov
2023-08-02  6:38               ` Wilhelm Kirschbaum
2023-08-16  2:11                 ` Dmitry Gutov
2023-10-07  8:46                   ` Wilhelm Kirschbaum
2023-10-07  9:59                     ` Wilhelm Kirschbaum
2023-10-07 10:10                       ` Wilhelm Kirschbaum
2023-10-21  7:39                         ` Wilhelm Kirschbaum
2023-10-26  0:27                           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leew7d7u.fsf@gmail.com \
    --to=wkirschbaum@gmail.com \
    --cc=64275@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=dmitry@gutov.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).