From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wilhelm Kirschbaum Newsgroups: gmane.emacs.bugs Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Mon, 31 Jul 2023 09:22:40 +0200 Message-ID: <87leew7d7u.fsf@gmail.com> References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40050"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.3; emacs 30.0.50 Cc: Basil Contovounesios , 64275@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 31 09:28:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qQNKL-000A9d-Jh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Jul 2023 09:28:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQNK3-0000bA-FG; Mon, 31 Jul 2023 03:28:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQNK0-0000YO-Vc for bug-gnu-emacs@gnu.org; Mon, 31 Jul 2023 03:28:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQNJx-0000H3-R7 for bug-gnu-emacs@gnu.org; Mon, 31 Jul 2023 03:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qQNJx-00022E-MP for bug-gnu-emacs@gnu.org; Mon, 31 Jul 2023 03:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wilhelm Kirschbaum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Jul 2023 07:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64275-submit@debbugs.gnu.org id=B64275.16907884507782 (code B ref 64275); Mon, 31 Jul 2023 07:28:01 +0000 Original-Received: (at 64275) by debbugs.gnu.org; 31 Jul 2023 07:27:30 +0000 Original-Received: from localhost ([127.0.0.1]:51712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQNJR-00021S-Tf for submit@debbugs.gnu.org; Mon, 31 Jul 2023 03:27:30 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:57779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQNJP-00021E-DG for 64275@debbugs.gnu.org; Mon, 31 Jul 2023 03:27:27 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3fbc1218262so45882515e9.3 for <64275@debbugs.gnu.org>; Mon, 31 Jul 2023 00:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690788441; x=1691393241; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=Wjma3nducrJ4qGRMN/CAFg47+t6o1St7m4U0Du4tVpw=; b=Nve+kT60xuW0c5vwOraJUL4J9Qa6c7FgwHGPzU89ibCoCBmDP1YCTM6Peb7XGZPr0N 92FxrcGgV8m6DYATLAvy5Af6AYBUFKh9jkMGc/0O9dcA01nSy1SPVF76+38OPRw+wwYf +XUGFBB+R3RWneCBfnumauiGjjFdXk/rM41bCztl5imlapdDjXESRIWGsUZpaqz3RDoJ 1V60prz2HHV3xAtg2u1dng57/hVbDaD2MMtkUlbQ9UM0eJEaGLQoUKjc89fVB9EZzki1 d3pirwehRSwh+utTAn+axcMVnThzTfsDnoMJGvrOcf0fASQW+BNBZfngcePB/CagTrrU X8Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690788441; x=1691393241; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Wjma3nducrJ4qGRMN/CAFg47+t6o1St7m4U0Du4tVpw=; b=DOJAdZTYTKI42v0LhjOvlIsYKb3BYagJ4QhJ7Ue+5ynq4ceNmHx4nu7wb3vEFk0YLL j9YRmCsQWt5a1vv4uALG308dJ/vhDUagQsZ+DKwfloKy5MqZLTQbv754IjdRcMhagZNn aeGQemYefu6F+M3kHfKZO9rVw5BeToO5OAcq3XYHVgEYYYwvDHWhWJ+7H+1iUED4PofT 69SBMiInUWRML9WNatRtBDKLMMgFR+rA0eaWO1rDelf/pJVXgnWPgwcUdiFJqG3xdZF7 +kzGHFV+8eXRYgkHWKKQp3mlgBhZcFfm9mex9jFPHc2tc4BGSwRd9+6xxlInRnTVgtgY Jv5A== X-Gm-Message-State: ABy/qLYI7yIWYP6/X39wlsOxP6miXK0/TAXQa+pT/fQjdx3SMB3HDsdQ 8l+JhkuzP6EsTETQfWJLLFANpeThCYCTzA== X-Google-Smtp-Source: APBJJlE8CK37CVfzBSYuGE4GOGs3rXjQ1JrNzsT7rz16mC8ec468JPwXlkotOqX86syenn69YAB66Q== X-Received: by 2002:a05:600c:2182:b0:3fe:90f:8496 with SMTP id e2-20020a05600c218200b003fe090f8496mr6907835wme.1.1690788441307; Mon, 31 Jul 2023 00:27:21 -0700 (PDT) Original-Received: from melissa.local ([2c0f:ef18:1431:0:b09:9616:db04:c248]) by smtp.gmail.com with ESMTPSA id m9-20020a7bce09000000b003fe1ddd6ac0sm3248199wmc.35.2023.07.31.00.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 00:27:21 -0700 (PDT) In-reply-to: <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266400 Archived-At: Dmitry Gutov writes: > On 30/07/2023 10:53, Wilhelm Kirschbaum wrote: >>> With the new patch, it will continue highlight the sigil name=20 >>> ("r") in >>> regexps, but no in other sigil types (s/c/w). >>> >> Incorrect, just below there is a: >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sigil) @font-lo= ck-string-face) >> without a match, so they will be highlighted, but just more >> generically >> as we don't know which sigils the user might have assigned. > > Why not add elixir-ts-font-sigil-name-face in that matcher as=20 > well? I think it is worth keeping the default/fallback case as simple as possible and if there is a need to add special font to more=20 specific cases. In this case it would have no impact if the font is not customized. Is there a reason you believe it would be better?