From: Eduard Wiebe <usenet@pusto.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 9409@debbugs.gnu.org
Subject: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode
Date: Tue, 13 Sep 2011 21:38:40 +0200 [thread overview]
Message-ID: <87k49cs05b.fsf@pusto.de> (raw)
In-Reply-To: <jwvhb4osf1q.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 07 Sep 2011 08:39:27 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> Can you apply this patch to the trunk.
>> I'm not sure if the change is appropriate, for all users of that macro.
>> (I don't have much of an opinion about it.)
>
> I think the change is a good one.
1+
> So if someone could check the various uses of that macro to make sure
> it doesn't break anything, we can install it.
I found following uses of the macro:
1889060 84 -rw-r--r-- 1 ew ew 80974 Sep 9 20:59 vc/diff-mode.el
1892302 24 -rw-r--r-- 1 ew ew 21559 Aug 27 17:25 vc/log-view.el
1892363 56 -rw-r--r-- 1 ew ew 51035 Aug 27 17:25 vc/smerge-mode.el
1889741 20 -rw-r--r-- 1 ew ew 17799 Aug 27 17:25 vc/cvs-status.el
I patched `easy-mmode-define-navigation' as above and tested (marked as X) the
most functions without any trouble.
* diff-mode.el
- [X] diff-hunk-prev
- [X] diff-hunk-next
- [X] diff-file-prev
- [X] diff-file-next
* log-view.el
- [X] log-view-msg-prev
- [X] log-view-msg-next
- [ ] log-view-file-prev
- [ ] log-view-file-next
* smerge-mode
- [ ] smerge-next
- [ ] smerge-prev
* cvs-status
- [X] cvs-status-next
- [X] cvs-status-prev
--
Eduard Wiebe
next prev parent reply other threads:[~2011-09-13 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 19:31 bug#9409: 24.0.50; log-view-msg-prev, easy-mmode Eduard Wiebe
2011-09-03 0:37 ` Glenn Morris
2011-09-03 17:41 ` Eduard Wiebe
2011-09-07 0:40 ` Glenn Morris
2011-09-07 12:39 ` Stefan Monnier
2011-09-13 19:38 ` Eduard Wiebe [this message]
2011-09-13 21:02 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k49cs05b.fsf@pusto.de \
--to=usenet@pusto.de \
--cc=9409@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).