From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eduard Wiebe Newsgroups: gmane.emacs.bugs Subject: bug#9409: 24.0.50; log-view-msg-prev, easy-mmode Date: Tue, 13 Sep 2011 21:38:40 +0200 Message-ID: <87k49cs05b.fsf@pusto.de> References: <87aaaqpufk.fsf@pusto.de> <96bov28nrf.fsf@fencepost.gnu.org> <87zkilfrrg.fsf@pusto.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315942966 15408 80.91.229.12 (13 Sep 2011 19:42:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 13 Sep 2011 19:42:46 +0000 (UTC) Cc: 9409@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 13 21:42:39 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R3YsQ-0005aD-Cq for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Sep 2011 21:42:38 +0200 Original-Received: from localhost ([::1]:56208 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3YsP-0007FM-RD for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Sep 2011 15:42:37 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:54294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3YsM-0007Eo-Dt for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2011 15:42:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3YsL-0000Te-B2 for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2011 15:42:34 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3YsL-0000TZ-8A for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2011 15:42:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R3Ywf-0001gD-Gt; Tue, 13 Sep 2011 15:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eduard Wiebe Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2011 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9409 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9409-submit@debbugs.gnu.org id=B9409.13159431686395 (code B ref 9409); Tue, 13 Sep 2011 19:47:01 +0000 Original-Received: (at 9409) by debbugs.gnu.org; 13 Sep 2011 19:46:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R3Yvn-0001f5-6o for submit@debbugs.gnu.org; Tue, 13 Sep 2011 15:46:07 -0400 Original-Received: from wp093.webpack.hosteurope.de ([80.237.132.100]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R3Yvk-0001ew-IB for 9409@debbugs.gnu.org; Tue, 13 Sep 2011 15:46:05 -0400 Original-Received: from f055098070.adsl.alicedsl.de ([78.55.98.70] helo=nirvana); authenticated by wp093.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) id 1R3YrO-0000Ho-41; Tue, 13 Sep 2011 21:41:34 +0200 Original-Received: from ew by nirvana with local (Exim 4.72) (envelope-from ) id 1R3Yoa-0001ej-ST; Tue, 13 Sep 2011 21:38:40 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 07 Sep 2011 08:39:27 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-bounce-key: webpack.hosteurope.de;ew@pusto.de;1315942896;aa6e41e4; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 13 Sep 2011 15:47:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51111 Archived-At: Stefan Monnier writes: >>> Can you apply this patch to the trunk. >> I'm not sure if the change is appropriate, for all users of that macro. >> (I don't have much of an opinion about it.) > > I think the change is a good one. 1+ > So if someone could check the various uses of that macro to make sure > it doesn't break anything, we can install it. I found following uses of the macro: 1889060 84 -rw-r--r-- 1 ew ew 80974 Sep 9 20:59 vc/diff-mode.el 1892302 24 -rw-r--r-- 1 ew ew 21559 Aug 27 17:25 vc/log-view.el 1892363 56 -rw-r--r-- 1 ew ew 51035 Aug 27 17:25 vc/smerge-mode.el 1889741 20 -rw-r--r-- 1 ew ew 17799 Aug 27 17:25 vc/cvs-status.el I patched `easy-mmode-define-navigation' as above and tested (marked as X) the most functions without any trouble. * diff-mode.el - [X] diff-hunk-prev - [X] diff-hunk-next - [X] diff-file-prev - [X] diff-file-next * log-view.el - [X] log-view-msg-prev - [X] log-view-msg-next - [ ] log-view-file-prev - [ ] log-view-file-next * smerge-mode - [ ] smerge-next - [ ] smerge-prev * cvs-status - [X] cvs-status-next - [X] cvs-status-prev -- Eduard Wiebe