* bug#36569: [PATCH] Fix warnings in todo-mode-tests.el
@ 2019-07-10 4:07 Stefan Kangas
2019-07-10 4:12 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2019-07-10 4:07 UTC (permalink / raw)
To: 36569
This patch fixes these warnings in make check:
ELC lisp/calendar/todo-mode-tests.elc
In toplevel form:
lisp/calendar/todo-mode-tests.el:565:1:Warning: Unused lexical argument
`where'
lisp/calendar/todo-mode-tests.el:565:1:Warning: Unused lexical argument `time'
lisp/calendar/todo-mode-tests.el:565:1:Warning: Unused lexical argument
`date-type'
lisp/calendar/todo-mode-tests.el:565:1:Warning: Unused lexical argument
`diary-type'
(I'll send the patch in a separate message once this is assigned a bug
number.)
Thanks,
Stefan Kangas
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#36569: [PATCH] Fix warnings in todo-mode-tests.el
2019-07-10 4:07 bug#36569: [PATCH] Fix warnings in todo-mode-tests.el Stefan Kangas
@ 2019-07-10 4:12 ` Stefan Kangas
2019-07-10 10:29 ` Basil L. Contovounesios
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2019-07-10 4:12 UTC (permalink / raw)
To: 36569
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
Stefan Kangas <stefan@marxist.se> writes:
> (I'll send the patch in a separate message once this is assigned a bug
> number.)
Patch attached.
Thanks,
Stefan Kangas
[-- Attachment #2: 0001-Fix-warnings-in-todo-mode-tests.el-Bug-36569.patch --]
[-- Type: application/octet-stream, Size: 1104 bytes --]
From a4ff7cf88379ddd7fdb962d261aceffdb5ed8089 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Wed, 10 Jul 2019 03:45:15 +0200
Subject: [PATCH] Fix warnings in todo-mode-tests.el (Bug#36569)
* test/lisp/calendar/todo-mode-tests.el (todo-test--insert-item):
Fix "Unused lexical argument" warnings.
---
test/lisp/calendar/todo-mode-tests.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/lisp/calendar/todo-mode-tests.el b/test/lisp/calendar/todo-mode-tests.el
index 7d4f7a7768..7d9425e2f5 100644
--- a/test/lisp/calendar/todo-mode-tests.el
+++ b/test/lisp/calendar/todo-mode-tests.el
@@ -572,7 +572,7 @@ todo-test--insert-item
(lambda (_prompt) item))
((symbol-function 'read-number) ; For todo-set-item-priority
(lambda (_prompt &optional _default) (or priority 1))))
- (todo-insert-item--basic)))
+ (todo-insert-item--basic nil diary-type date-type time where)))
(ert-deftest todo-test-toggle-item-header07 () ; bug#27609
"Test display of hidden item header under todo-insert-item."
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#36569: [PATCH] Fix warnings in todo-mode-tests.el
2019-07-10 4:12 ` Stefan Kangas
@ 2019-07-10 10:29 ` Basil L. Contovounesios
0 siblings, 0 replies; 3+ messages in thread
From: Basil L. Contovounesios @ 2019-07-10 10:29 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 36569-done
tags 36569 fixed
close 36569 27.1
quit
Stefan Kangas <stefan@marxist.se> writes:
> Patch attached.
Thanks, I pushed it to master[1] and am therefore closing this report.
[1]: Fix warnings in todo-mode-tests.el (Bug#36569)
c198ecda9f 2019-07-10 11:26:18 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c198ecda9f51c3bc35d9709d0dc2c4b87ec4ee6e
--
Basil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-10 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 4:07 bug#36569: [PATCH] Fix warnings in todo-mode-tests.el Stefan Kangas
2019-07-10 4:12 ` Stefan Kangas
2019-07-10 10:29 ` Basil L. Contovounesios
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).