unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#52154: 29.0.50; tabulated-list-sort errors if N arg is out of range
@ 2021-11-28  4:24 No Wayman
  2021-11-29 15:39 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: No Wayman @ 2021-11-28  4:24 UTC (permalink / raw)
  To: 52154

If tabulated-list-sort is passed a numeric arg that is out of 
range with respect to tabulated-list-format, an out-of-range error 
is thrown.
Would it be better to clamp the numeric arg to (1- (length 
tabulated-list-format))?
If not, should we user-error instead of error?

~ Nick

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, 
cairo version 1.17.4, Xaw3d scroll bars)
 of 2021-11-22 built on nbook
Repository revision: 9ceb3070e34ad8a54184fd0deda477bf5ff77000
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 
11.0.12101001
System Description: Arch Linux






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#52154: 29.0.50; tabulated-list-sort errors if N arg is out of range
  2021-11-28  4:24 bug#52154: 29.0.50; tabulated-list-sort errors if N arg is out of range No Wayman
@ 2021-11-29 15:39 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-11-29 15:39 UTC (permalink / raw)
  To: No Wayman; +Cc: 52154

No Wayman <iarchivedmywholelife@gmail.com> writes:

> If tabulated-list-sort is passed a numeric arg that is out of range
> with respect to tabulated-list-format, an out-of-range error is
> thrown.
> Would it be better to clamp the numeric arg to (1- (length
> tabulated-list-format))?
> If not, should we user-error instead of error?

I've now done the latter in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-29 15:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-28  4:24 bug#52154: 29.0.50; tabulated-list-sort errors if N arg is out of range No Wayman
2021-11-29 15:39 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).