unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 53989@debbugs.gnu.org
Subject: bug#53989: 29.0.50; Gnus searches broken
Date: Fri, 18 Feb 2022 03:10:07 +0100	[thread overview]
Message-ID: <87k0dtq60w.fsf@web.de> (raw)
In-Reply-To: <8735kjd89w.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 15 Feb 2022 15:23:07 -0800")

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Okay, it turns out that also lets us drop most of the regexp silliness
> from the parsing stuff. Would you mind trying the attached patch and
> confirm that it doesn't break anything? I'll try to make this the last
> time I mess with search results parsing...

Works so far for me.

| +(cl-defmethod gnus-search-indexed-extract :around
| +  ((_engine gnus-search-indexed))
| +  (let ((ret (cl-call-next-method)))

Why do you need an :around method here - why don't you just add that to
the primary method?

| +    ;; We run `expand-file-name' here in order to collapse multiple
| +    ;; consecutive directory separators.
| +    (cl-callf expand-file-name (car ret))
| +    ret))

If I were you I would add to the comment that mairix may return such
multi-separator file names - else it's not clear why that collapsing is
necessary at that point.


Thanks,

Michael.





  reply	other threads:[~2022-02-18  2:10 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-14  3:37 bug#53989: 29.0.50; Gnus searches broken Michael Heerdegen
2022-02-14  4:23 ` Eric Abrahamsen
2022-02-14  4:59   ` Michael Heerdegen
2022-02-14  5:19     ` Michael Heerdegen
2022-02-14  6:06       ` Eric Abrahamsen
2022-02-14 22:11       ` Eric Abrahamsen
2022-02-14 22:41         ` Eric Abrahamsen
2022-02-14 23:06           ` Michael Heerdegen
2022-02-14 23:22             ` Eric Abrahamsen
2022-02-14 22:49         ` Michael Heerdegen
2022-02-14 23:08           ` Eric Abrahamsen
2022-02-14 23:21             ` Michael Heerdegen
2022-02-14 23:24               ` Eric Abrahamsen
2022-02-14 23:31                 ` Michael Heerdegen
2022-02-14 23:35                   ` Eric Abrahamsen
2022-02-14 23:40                   ` Michael Heerdegen
2022-02-14 23:45                     ` Eric Abrahamsen
2022-02-15  0:37                       ` Andreas Schwab
2022-02-15  1:29                         ` Eric Abrahamsen
2022-02-15  2:48                       ` Michael Heerdegen
2022-02-15  3:45                         ` Eric Abrahamsen
2022-02-15  4:20                           ` Michael Heerdegen
2022-02-15 23:23                             ` Eric Abrahamsen
2022-02-18  2:10                               ` Michael Heerdegen [this message]
2022-02-18 16:01                                 ` Eric Abrahamsen
2022-02-19  1:07                                   ` Michael Heerdegen
2022-02-19  1:20                                     ` Eric Abrahamsen
2022-02-19  1:29                                       ` Michael Heerdegen
2022-02-14  6:05     ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0dtq60w.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=53989@debbugs.gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).