From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#53989: 29.0.50; Gnus searches broken Date: Fri, 18 Feb 2022 03:10:07 +0100 Message-ID: <87k0dtq60w.fsf@web.de> References: <874k52i0ef.fsf@web.de> <87v8xijcuo.fsf@ericabrahamsen.net> <875ypicac2.fsf@web.de> <871r06c9ed.fsf@web.de> <874k51hzey.fsf@ericabrahamsen.net> <874k51qd1k.fsf@web.de> <87ee45gi6j.fsf@ericabrahamsen.net> <87v8xhowz1.fsf@web.de> <871r05ghfj.fsf@ericabrahamsen.net> <87pmnpowif.fsf@web.de> <87h791ow4f.fsf@web.de> <87pmnpf1wq.fsf@ericabrahamsen.net> <87wnhw9759.fsf@web.de> <878rucg5cu.fsf@ericabrahamsen.net> <87v8xg7oce.fsf@web.de> <8735kjd89w.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6514"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53989@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 18 03:11:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKsjn-0001UG-Ic for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Feb 2022 03:11:11 +0100 Original-Received: from localhost ([::1]:50910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKsjm-00009S-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 21:11:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKsje-00009J-I9 for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 21:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59166) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKsje-0007zF-8W for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 21:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKsje-0001Ij-2Z for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 21:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Feb 2022 02:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53989 X-GNU-PR-Package: emacs Original-Received: via spool by 53989-submit@debbugs.gnu.org id=B53989.16451502264956 (code B ref 53989); Fri, 18 Feb 2022 02:11:02 +0000 Original-Received: (at 53989) by debbugs.gnu.org; 18 Feb 2022 02:10:26 +0000 Original-Received: from localhost ([127.0.0.1]:53063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKsj3-0001Hs-U2 for submit@debbugs.gnu.org; Thu, 17 Feb 2022 21:10:26 -0500 Original-Received: from mout.web.de ([212.227.15.4]:55355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKsj1-0001Ha-M1 for 53989@debbugs.gnu.org; Thu, 17 Feb 2022 21:10:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1645150208; bh=8IhMbqQ6IrE1MOGVyWYvR0yTWdGJFzBjrTxWzE5IHos=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=hrmMDpaBIyc/n7G1llgyOox9fJWmrA7IsF4kNH/1hDRdmenGOIw7D62YwGo198++t 17Z01aTCSVshrAGQwHTL85LsRUdAn+DkPWQy7UbXa086aXo8kfsSvC9KxExyuYpv1T siCf85qqlhh/0Rv4/rjOCRnLL9fZCstJLhVoAIuE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MREzA-1nfs3Q0o2G-00NPlI; Fri, 18 Feb 2022 03:10:08 +0100 In-Reply-To: <8735kjd89w.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 15 Feb 2022 15:23:07 -0800") X-Provags-ID: V03:K1:WJHCkHfzTBMyhn3fviJDx7rUKTnj/Z7vxg4g+B5YuN6YqNWrXcA kmQPUwlRXUtkTdfoscx2O65QRf8pZJZ42oXOdQSJipYjdSXzUhxh4iXAKO0PR/XKoNxZ4sx FypwVh1qMpF2O/yW4Mw56n8/RKTHBolySNjxM2Z5KmXb5aNMxAiop4CwrpxeBdD6UXl2sht EvzfkMtUt+94N+m/iRhRg== X-UI-Out-Filterresults: notjunk:1;V03:K0:E/lqHA7hVkQ=:zDkqz8DZZldZ+GQwiMKo8B RmF9dY0R061XrSei+0hIQy6OOHwGwM7mWoACLbNLtjdIo5i7k8gpJ/7PeslKo+8Q3VrhhpPj/ uRto0haINqU2k3q0RCDpsgDo0tCxDqmX+6OTcKn/ZvysUY3BWiAtLEaIyHaL4RftG1FgFmY64 tPX0Un1F4vSvW2qyy8ODmDjjkoMC7Ac6XibQN5HDspqjkJcXKZf/hGYTLeQHpidZNuZWZVA8w 09ruMGBM0NyeekRAv6jQj8LPzKOwgMTCgl6KRaJU8N0RoGDsrjYo3fltPPEzg+R73sjo4gdhE W9icONK3Een9bmEYYaklxMHbNzgfNDhdZRI3uTnFzx/2zh5SSBJI+dVMUhTg8BNpURDvDE9Wi /qcDB3fuljiYVMrTxw+gwzysx2rRQHgQMj6MmR8TKUncwbBeQQstIvQFwIyvzOMu9KDhrcLHb NNS5gcviskkjeDs9g62H3QeFqXcAklJ/EQY8HGEeX06YwLhfWZ+Mm91rJ3YKEe9i9FORrL2Bc XnLLc5Trl5PAMXlyn1WB/LuDs+lZbeJi2g6teevSIdTnWYUjtRP1Oa7CwaI5tr4J7bmv8jqac AJasHRp2WViq3/dv20VEK6YG7IY7cghQDy1iyPRFQhhKnuMsPUPuvcVlomc9nuV68CB2dd5S/ olvjEyKCO8cP7fD4htv1X9anP2tdg6MWlH26NZRZI5N2s5BZL+8bhYkoY9Qp7yIkFJwdytNLq 6dRK0s+8lDy/6cNryBswRGAo2xTNET21Zot1ujPYXLPMzV+3xUmXuDQDDo5HgUd9oc5E0no1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227131 Archived-At: Eric Abrahamsen writes: > Okay, it turns out that also lets us drop most of the regexp silliness > from the parsing stuff. Would you mind trying the attached patch and > confirm that it doesn't break anything? I'll try to make this the last > time I mess with search results parsing... Works so far for me. | +(cl-defmethod gnus-search-indexed-extract :around | + ((_engine gnus-search-indexed)) | + (let ((ret (cl-call-next-method))) Why do you need an :around method here - why don't you just add that to the primary method? | + ;; We run `expand-file-name' here in order to collapse multiple | + ;; consecutive directory separators. | + (cl-callf expand-file-name (car ret)) | + ret)) If I were you I would add to the comment that mairix may return such multi-separator file names - else it's not clear why that collapsing is necessary at that point. Thanks, Michael.