From: Vladimir Nikishkin <lockywolf@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 55329@debbugs.gnu.org
Subject: bug#55329: [PATCH] Choose latex environment for table.el export
Date: Mon, 09 May 2022 19:28:29 +0800 [thread overview]
Message-ID: <87k0avlzc2.fsf@laptop.lockywolf.net> (raw)
In-Reply-To: <834k1zuevk.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Vladimir Nikishkin <lockywolf@gmail.com>
>> Date: Mon, 09 May 2022 10:30:57 +0800
>>
>> The patch creates 1 new customize variable:
>> 1. table-latex-environment
>>
>> And changes the following 2 functions:
>> 1. table--generate-source-epilogue
>> 2. table--generate-source-prologue
>
> Thanks. A couple of minor nits:
>
>> +(defcustom table-latex-environment "tabular"
>> + "Which tabular-compatible environment to use when generating latex.
>> +tabular and longtable are known to work."
>
> I'm not sure I understand the purpose of the last sentence, nor what
> it adds to the doc string.
>
> Also, perhaps we should prefer symbol values, not string values here?
> Symbols are easier to compare and harder to make mistakes.
I think this is a duplicate bug, I am sorry. This patch has already been
reviewed and accepted by Lars Ingebrigtsen.
> I'm not sure I understand the purpose of the last sentence, nor what
> Symbols are easier to compare and harder to make mistakes.
This setting accepts a free-form write-in. There may be more Latex
environments satisfying the "tabular" protocol, not just "tabular"
itself and "longtable". I haven't done an extensive survey, but I
suspect that most do. If this value is interpreted as a symbol, it
would require a "symbol->string" at the time of actually writing
the code into the final buffer. I don't think that a symbol would
really fit here.
--
Your sincerely,
Vladimir Nikishkin (MiEr, lockywolf)
(Laptop)
prev parent reply other threads:[~2022-05-09 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 2:30 bug#55329: [PATCH] Choose latex environment for table.el export Vladimir Nikishkin
2022-05-09 10:05 ` bug#55333: " Lars Ingebrigtsen
2022-05-09 11:25 ` bug#55329: " Eli Zaretskii
2022-05-09 11:28 ` Vladimir Nikishkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0avlzc2.fsf@laptop.lockywolf.net \
--to=lockywolf@gmail.com \
--cc=55329@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).