From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Nikishkin Newsgroups: gmane.emacs.bugs Subject: bug#55329: [PATCH] Choose latex environment for table.el export Date: Mon, 09 May 2022 19:28:29 +0800 Message-ID: <87k0avlzc2.fsf@laptop.lockywolf.net> References: <87ee13wi72.fsf@laptop.lockywolf.net> <834k1zuevk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12780"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.3; emacs 29.0.50 Cc: 55329@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 13:36:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no1gj-0003BT-36 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 13:36:29 +0200 Original-Received: from localhost ([::1]:51790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no1gi-0000EX-4v for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 07:36:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no1eM-00073j-Hd for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no1eM-0005Uu-7i for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no1eM-0004e4-5O for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vladimir Nikishkin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 11:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55329-submit@debbugs.gnu.org id=B55329.165209602117815 (code B ref 55329); Mon, 09 May 2022 11:34:02 +0000 Original-Received: (at 55329) by debbugs.gnu.org; 9 May 2022 11:33:41 +0000 Original-Received: from localhost ([127.0.0.1]:56416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no1e0-0004dH-W5 for submit@debbugs.gnu.org; Mon, 09 May 2022 07:33:41 -0400 Original-Received: from mail-pl1-f170.google.com ([209.85.214.170]:33645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no1dx-0004d1-A3 for 55329@debbugs.gnu.org; Mon, 09 May 2022 07:33:39 -0400 Original-Received: by mail-pl1-f170.google.com with SMTP id d17so13594537plg.0 for <55329@debbugs.gnu.org>; Mon, 09 May 2022 04:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=BJHkLNESrunssYH0EBTwiaWenUyNGX00NxKLY10lmBk=; b=oBwOMGsb0Hc4PWVrB3GU0QjC0TpATGDqWIWFxooRQ6Adadhe+NEUx5O3ZDq4xn26HW GEb2dKZpwD/3Trp4rjXJoJ0oxw3rAdAizmFhVDzRh4ZJUjJ/C1RJjifmVRGgYwO1qXHE 9KleK+kxG9bdwF1/elRquRq/XVit0mVUbb/6LFoKNeN9siwta0ELbxsuJwSgnYQbSK7s S3FzBA620GI+9RakgDagJkpAqlxp9EZ8VBSS5L1NcGSBQSJMvYgKBToBU8NVSNfZu6th nUftJzjK3GM6XAVCqkg+ZAkz1l6kK7dCwZAkNj0MwgEsAxzxxO/49hIy9/jDybJWBojq 9pIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=BJHkLNESrunssYH0EBTwiaWenUyNGX00NxKLY10lmBk=; b=j+vXxeP6c/tP0MXONIkfW/0SrSmohLaP/MPe1lX0EboFIhRUmxhT9v6BnceGK74b+3 D1zZWUgltp0i+SJXx/9fhmUyfgH8j78CMgO/ipKN51tL7MjzXZ4yli8yjB0gm0E1st8a kpB9FuCM3sk0OUX16xt2R214CIxy09q1/5w8iiSWyuI2Q7k24tLIPave6dK2OfvmxQdl 34HwvtpshixXT8pZyKykshsMQEuvugS+ZQWc+9xWSkXMtem6lDpmwUNX+pfVcyokKVfn F18BKzF/QnEItfh55RX9MnGVKvF3QI0GHrbwJFp045v81Ydp0c/66BMYHrzd9yZMpCcX dN4Q== X-Gm-Message-State: AOAM533SVgiLOIS7WM8+dIj68u96w8OiCB7aWTzFkgtuA4dTOUd6E/rM Nw2qdzKDH73F0Jqy3WpEvsxRfs7fmkAw1g== X-Google-Smtp-Source: ABdhPJx7u1BdZmZ1CtUTANc/GznD/OtyK6+MWv3gza9RG/GEKAUUidLh2l1NLSolmcMbPl5UdH1ZTQ== X-Received: by 2002:a17:902:e806:b0:15e:7f0c:ce2b with SMTP id u6-20020a170902e80600b0015e7f0cce2bmr15742736plg.100.1652096011034; Mon, 09 May 2022 04:33:31 -0700 (PDT) Original-Received: from laptop.lockywolf.net ([2001:470:24:315::102]) by smtp.gmail.com with ESMTPSA id c2-20020a170902d90200b0015eb6d49679sm6861483plz.62.2022.05.09.04.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 04:33:30 -0700 (PDT) In-reply-to: <834k1zuevk.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231725 Archived-At: Eli Zaretskii writes: >> From: Vladimir Nikishkin >> Date: Mon, 09 May 2022 10:30:57 +0800 >> >> The patch creates 1 new customize variable: >> 1. table-latex-environment >> >> And changes the following 2 functions: >> 1. table--generate-source-epilogue >> 2. table--generate-source-prologue > > Thanks. A couple of minor nits: > >> +(defcustom table-latex-environment "tabular" >> + "Which tabular-compatible environment to use when generating latex. >> +tabular and longtable are known to work." > > I'm not sure I understand the purpose of the last sentence, nor what > it adds to the doc string. > > Also, perhaps we should prefer symbol values, not string values here? > Symbols are easier to compare and harder to make mistakes. I think this is a duplicate bug, I am sorry. This patch has already been reviewed and accepted by Lars Ingebrigtsen. > I'm not sure I understand the purpose of the last sentence, nor what > Symbols are easier to compare and harder to make mistakes. This setting accepts a free-form write-in. There may be more Latex environments satisfying the "tabular" protocol, not just "tabular" itself and "longtable". I haven't done an extensive survey, but I suspect that most do. If this value is interpreted as a symbol, it would require a "symbol->string" at the time of actually writing the code into the final buffer. I don't think that a symbol would really fit here. -- Your sincerely, Vladimir Nikishkin (MiEr, lockywolf) (Laptop)