From: Stefan Kangas <stefan@marxist.se>
To: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
Cc: 38084@debbugs.gnu.org, 38085@debbugs.gnu.org,
Tino Calancha <tino.calancha@gmail.com>
Subject: bug#38084: bug#38085: [PATCH] Two functions named ‘package-menu--refresh’
Date: Wed, 06 Nov 2019 15:13:31 +0100 [thread overview]
Message-ID: <87imnxxfck.fsf@marxist.se> (raw)
In-Reply-To: <fv2zojo8xp8har.fsf@gmail.com> (Dario Gjorgjevski's message of "Wed, 06 Nov 2019 10:50:36 +0100")
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
Dario Gjorgjevski <dario.gjorgjevski@gmail.com> writes:
> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> I mean, this is bug 38084
>
> Thanks; I did not realize that there is already a bug. Here is an
> amended patch which references bug#38084 in the commit message.
Thanks, I installed a slightly different patch (attached) which I
believe fixes this.
Best regards,
Stefan Kangas
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-problem-with-my-last-commit-in-package.el.patch --]
[-- Type: text/x-diff, Size: 1904 bytes --]
From d30f5e7eeecd5425e236542189a1d683c00e7ed7 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Wed, 6 Nov 2019 14:48:23 +0100
Subject: [PATCH] Fix problem with my last commit in package.el
* lisp/emacs-lisp/package.el (package-menu--refresh-archives): Rename
from duplicated name package-menu--refresh. (Bug#38084)
(package-menu-mode, list-packages): Use new name.
---
lisp/emacs-lisp/package.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index b7a528dac4..9f8ee8368e 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2767,7 +2767,7 @@ package-menu-mode
(setq tabulated-list-sort-key (cons "Status" nil))
(add-hook 'tabulated-list-revert-hook #'package-menu--refresh nil t)
(tabulated-list-init-header)
- (setq revert-buffer-function 'package-menu--refresh)
+ (setq revert-buffer-function 'package-menu--refresh-contents)
(setf imenu-prev-index-position-function
#'package--imenu-prev-index-position-function)
(setf imenu-extract-index-name-function
@@ -3166,7 +3166,7 @@ package-menu--print-info-simple
(defvar package-menu--old-archive-contents nil
"`package-archive-contents' before the latest refresh.")
-(defun package-menu--refresh (&optional _arg _noconfirm)
+(defun package-menu--refresh-contents (&optional _arg _noconfirm)
"In Package Menu, download the Emacs Lisp package archive.
Fetch the contents of each archive specified in
`package-archives', and then refresh the package menu. Signal a
@@ -3646,7 +3646,7 @@ list-packages
(package-menu-mode)
;; Fetch the remote list of packages.
- (unless no-fetch (package-menu--refresh))
+ (unless no-fetch (package-menu--refresh-contents))
;; If we're not async, this would be redundant.
(when package-menu-async
--
2.20.1
next prev parent reply other threads:[~2019-11-06 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 9:10 bug#38085: [PATCH] Two functions named ‘package-menu--refresh’ Dario Gjorgjevski
2019-11-06 9:29 ` Tino Calancha
2019-11-06 9:30 ` Tino Calancha
2019-11-06 9:50 ` Dario Gjorgjevski
2019-11-06 14:13 ` Stefan Kangas [this message]
2019-11-06 14:20 ` Dario Gjorgjevski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imnxxfck.fsf@marxist.se \
--to=stefan@marxist.se \
--cc=38084@debbugs.gnu.org \
--cc=38085@debbugs.gnu.org \
--cc=dario.gjorgjevski@gmail.com \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).