From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#38084: bug#38085: [PATCH] Two functions named =?UTF-8?Q?=E2=80=98package-menu--refresh=E2=80=99?= Date: Wed, 06 Nov 2019 15:13:31 +0100 Message-ID: <87imnxxfck.fsf@marxist.se> References: <87o8xp1hdu.fsf@ip-10-207-252-54.us-west-2.compute.internal> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49179"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38084@debbugs.gnu.org, 38085@debbugs.gnu.org, Tino Calancha To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 06 15:14:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSM4m-000CfH-I7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2019 15:14:24 +0100 Original-Received: from localhost ([::1]:59276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSM4l-0005cf-7Q for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2019 09:14:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55478) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSM4R-0005aB-0G for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 09:14:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSM4P-0000zz-Tm for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 09:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSM4P-0000zt-PB for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 09:14:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iSM4P-000568-Ir for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 09:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2019 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38084 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38084-submit@debbugs.gnu.org id=B38084.157304962119551 (code B ref 38084); Wed, 06 Nov 2019 14:14:01 +0000 Original-Received: (at 38084) by debbugs.gnu.org; 6 Nov 2019 14:13:41 +0000 Original-Received: from localhost ([127.0.0.1]:39642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSM45-00055F-CS for submit@debbugs.gnu.org; Wed, 06 Nov 2019 09:13:41 -0500 Original-Received: from host.gofardesign.uk ([208.79.239.190]:56025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSM43-00054x-Hc; Wed, 06 Nov 2019 09:13:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DsOghDnGvVIQczAxEPgevA6irR0awte7rcxJ8aB34mY=; b=PyZ01hUc6gUY7rB0G6BhwBD+BI KSY1BjQJCRRVL9NamOnNixnRSW2RHxHfEpYR4ZxH/mTM8+3gf9Jx1f1juQYzO7bvrs9e86Eh3Wa+F N47GQrW2q++x1ZJ5JI1yxiAFhnECOeeyylWhBOLdxHFEE4bOOnYZrIVT0OfBPxp39Th8=; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:44392 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iSM3x-00072m-8V; Wed, 06 Nov 2019 08:13:34 -0600 In-Reply-To: (Dario Gjorgjevski's message of "Wed, 06 Nov 2019 10:50:36 +0100") X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171023 Archived-At: --=-=-= Content-Type: text/plain Dario Gjorgjevski writes: > Tino Calancha writes: > >> I mean, this is bug 38084 > > Thanks; I did not realize that there is already a bug. Here is an > amended patch which references bug#38084 in the commit message. Thanks, I installed a slightly different patch (attached) which I believe fixes this. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-problem-with-my-last-commit-in-package.el.patch >From d30f5e7eeecd5425e236542189a1d683c00e7ed7 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Wed, 6 Nov 2019 14:48:23 +0100 Subject: [PATCH] Fix problem with my last commit in package.el * lisp/emacs-lisp/package.el (package-menu--refresh-archives): Rename from duplicated name package-menu--refresh. (Bug#38084) (package-menu-mode, list-packages): Use new name. --- lisp/emacs-lisp/package.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index b7a528dac4..9f8ee8368e 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2767,7 +2767,7 @@ package-menu-mode (setq tabulated-list-sort-key (cons "Status" nil)) (add-hook 'tabulated-list-revert-hook #'package-menu--refresh nil t) (tabulated-list-init-header) - (setq revert-buffer-function 'package-menu--refresh) + (setq revert-buffer-function 'package-menu--refresh-contents) (setf imenu-prev-index-position-function #'package--imenu-prev-index-position-function) (setf imenu-extract-index-name-function @@ -3166,7 +3166,7 @@ package-menu--print-info-simple (defvar package-menu--old-archive-contents nil "`package-archive-contents' before the latest refresh.") -(defun package-menu--refresh (&optional _arg _noconfirm) +(defun package-menu--refresh-contents (&optional _arg _noconfirm) "In Package Menu, download the Emacs Lisp package archive. Fetch the contents of each archive specified in `package-archives', and then refresh the package menu. Signal a @@ -3646,7 +3646,7 @@ list-packages (package-menu-mode) ;; Fetch the remote list of packages. - (unless no-fetch (package-menu--refresh)) + (unless no-fetch (package-menu--refresh-contents)) ;; If we're not async, this would be redundant. (when package-menu-async -- 2.20.1 --=-=-=--