unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Matthias Meulien <orontee@gmail.com>
Cc: 39722@debbugs.gnu.org
Subject: bug#39722: Support for bookmark.el in VC directory buffers
Date: Wed, 13 May 2020 01:46:05 +0300	[thread overview]
Message-ID: <87imh0n80q.fsf@mail.linkov.net> (raw)
In-Reply-To: <4738c0198ff32df9ea59906ef055e68838e921f0.camel@gmail.com> (Matthias Meulien's message of "Fri, 21 Feb 2020 22:19:34 +0100")

> Being able to bookmark VC directory buffers is useful when working on
> multiple projects; The proposed patch implements this on the lines of
> what I read in info.el.

Thanks, this is a useful addition.  Please push it after fixing minor
details:

> +(defun vc-dir-bookmark-make-record ()
> +  "This implements the `bookmark-make-record-function' type for
> +`vc-dir' buffers."
> ...
> +(defun vc-dir-bookmark-jump (bmk)
> +  "This implements the `handler' function interface for the record
> +type returned by `vc-dir-bookmark-make-record'."

According to the documentation standard described in
(info "(elisp) Documentation Tips")
the first line of the docstring should consist of a complete sentence.

I see that you copied the docstring from Info-bookmark-jump,
but the docstrings of info.el contains a mistake
that should be fixed in info.el.





  reply	other threads:[~2020-05-12 22:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 21:19 bug#39722: Support for bookmark.el in VC directory buffers Matthias Meulien
2020-05-12 22:46 ` Juri Linkov [this message]
2020-05-13  0:35   ` Matthias Meulien
2020-05-20 22:38     ` Juri Linkov
2020-06-04 22:42 ` Juri Linkov
2020-06-06 23:52   ` Juri Linkov
2020-06-21 23:36     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imh0n80q.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=39722@debbugs.gnu.org \
    --cc=orontee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).